Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [m2e-users] feedback M2E Ingio - m2e connector concept

I don't think @dereciated is an apt analogy, its simply a warning that your code may not work in the future.  m2e can't know what the result of not executing a plugin, it may be irrelevant or it may break the project entirely.  If the marker were simply a warning we'd undoubtedly see people complaining that projects weren't working and they weren't given any explanation as to why.

To my knowledge an error marker doesn't block anything, you'd see a prompt when executing but you can choose not to be shown it in the future.

Matthew

On 24 June 2011 11:39, Max Rydahl Andersen <max.andersen@xxxxxxxxxx> wrote:
> Now, knowing that going back to the old behaviour is not a solution, what are your proposals to improve the situation?

IMO the same thing I believe many others have suggested before:

Give a way for users to downgrade the Error marker to a Warning so they do not need to
edit their team shared pom or non-owned pom (i.e. just trying out a project)

Note: for those who want to avoid having this error pollute you can edit the problem view to exclude this specific error type.
That might hide other problems, but this is the best way I've found to avoid seeing people look in fear when the
project is filled up with red lights.

IMO the marker should have been a warning from start since the project does work; its just skipping the unsupported parts.

Just like @deprecated usage in Eclipse is a warning not an error by default since the method might be wrong but most likely
does not hurt.

But I know Igor and Jason thinks Big Red Error Markers is the only way to get users attention - I disagree on that :)

/max
One that reads and notices warnings :)


>
>
>
> On 2011-06-24, at 10:26 AM, Honnix Liang wrote:
>
>> Totally agreed.
>>
>> This update almost corrupts all of my existing projects. I have to
>> rollback to earlier version.
>>
>> Please consider backward compatibility when doing such a huge change.
>>
>> BTW, I also didn't see any benefit except mass. Why should I put
>> Eclipse stuff in pom.xml and other guys in team are using Intellij for
>> example?
>>
>> On Fri, Jun 24, 2011 at 6:45 PM, Moser, Christian <cmo@xxxxxxxxxxx> wrote:
>>> Just tried out our build environment with Indigo and m2e
>>> 1.0.0.20110607-2117.
>>>
>>>
>>>
>>> User-experience :
>>>
>>>
>>>
>>> After a full import of all maven projects, I’ve received following error in
>>> almost every pom:
>>>
>>>
>>>
>>> Plugin execution not covered by lifecycle configuration: …
>>>
>>>
>>>
>>> After clicking around for some time, I found under pom.xml / Overview the
>>> possibility to ignore those «not covered plugin-lifecycles »
>>>
>>>
>>>
>>> Unfortunately, this modified my pom and added :
>>>
>>>
>>>
>>> <pluginManagement>
>>>
>>>             <plugins>
>>>
>>>                    <!--This plugin's configuration is used to store Eclipse
>>> m2e settings only. It has no influence on the Maven build itself.-->
>>>
>>>                    <plugin>
>>>
>>>                           <groupId>org.eclipse.m2e</groupId>
>>>
>>>                           <artifactId>lifecycle-mapping</artifactId>
>>>
>>>                           <version>1.0.0</version>
>>>
>>>                           <configuration>
>>>
>>>                                  …
>>>
>>>                           </configuration>
>>>
>>>                    </plugin>
>>>
>>>             </plugins>
>>>
>>>       </pluginManagement>
>>>
>>>
>>>
>>> In the import wizard, after m2e didn‘t found lifecycle connectors, there
>>> should be a combobox in the Action column displayed BEFORE the user clicks
>>> an cell. Otherwise it’s not easy to unterstand that this cell is editable.
>>>
>>>
>>>
>>> Opinion :
>>>
>>>
>>>
>>> In my view, is the attempt to store M2e settings within a platform and !IDE!
>>> independent element, such as pom.xml utterly the wrong place!
>>>
>>>
>>>
>>> I’m using maven because it is an independent build tool, which does not care
>>> what is used for developing or building maven projects! Even if maven or
>>> other IDE’s don’t care for those excludes (eventually..), I don’t wanna be
>>> forced to edit all my pom’s or at least the parents (If you got any..) for
>>> developing with Eclipse.
>>>
>>>
>>>
>>> Is there a possibility to disable this new m2e connector feature by
>>> default ?
>>>
>>>
>>>
>>> My suggestions:
>>>
>>> -    Store m2e connector excludes anywhere but in the pom.xml
>>>
>>> -    Disable m2e connector feature by default
>>>
>>> -    Documentation for m2e connectors (what are the advantages ?)
>>>
>>>
>>>
>>> Just my two coins,
>>>
>>> Regards Christian
>>>
>>>
>>>
>>> _______________________________________________
>>> m2e-users mailing list
>>> m2e-users@xxxxxxxxxxx
>>> https://dev.eclipse.org/mailman/listinfo/m2e-users
>>>
>>>
>> _______________________________________________
>> m2e-users mailing list
>> m2e-users@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/m2e-users
>
> _______________________________________________
> m2e-users mailing list
> m2e-users@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/m2e-users

/max
http://about.me/maxandersen



_______________________________________________
m2e-users mailing list
m2e-users@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/m2e-users


Back to the top