[m2e-dev] Bug 548948 - m2e ignores the 'Exclude Test Code' checkbox

[Alexandros Karypidis <akarypid@xxxxxxxx>]

Hello,

I've raised and submitted a patch for this a while back but it was never reviewed. It's been driving me nuts that I manually build m2e to patch the issue on my Eclipse. I'm really hoping someone can review the patch and merge the fix to master so that it eventually gets released?

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=548948

Gerrit change: https://git.eclipse.org/r/#/c/146110/

Personally, I'd go with deleting all the heuristics in getArtifactScope() and just use JDT settings in all cases, but I have modified the patch to only look at the JDT flag when it is present and use the old heuristics if it is missing. (I did this in case there were concerns about backwards compatibility as discussed in the bug, though personally I think it'd be best if we just get rid of the heuristics altogether now that Eclipse has proper test scope settings in JDT).

Would really appreciate it if someone reviewed and told me what this needs to get merged.

I've run all unit/integration tests and they pass.

On that note: I have a couple of unit tests added to https://github.com/tesla/m2e-core-tests/blob/master/org.eclipse.m2e.tests/src/org/eclipse/m2e/tests/launch/MavenRuntimeClasspathProviderTest.java  (along with a test project in the resources folder). How do I go about raising a PR for the github repo to get the new tests accompanying this change? Do I just clone it on github and raise a PR there?