| Re: [lts-iwg] Running offline builds for LTS |
|
Thanks Wayne, Szymon,
What I decided to do was changed the Author to Pascal and added links to the related commits on the community side that this patch is based on. I then added a sign-off for myself and committer is still set to myself. The new patch is now on Gerrit for further review. Thanh On 03/07/13 10:41 AM, Szymon Ptaszkiewicz wrote: Thanks Wayne! Szymon From: Wayne Beaton <wayne@xxxxxxxxxxx> To: lts-iwg@xxxxxxxxxxx Date: 2013-07-03 16:21 Subject: Re: [lts-iwg] Running offline builds for LTS Sent by: lts-iwg-bounces@xxxxxxxxxxx If the content being committed is wholly-authored by another individual, then that individual's credentials need to be in the author field. The simple rule is that the author is the author. If the content is partially authored by more than one person, then you can add "Also-by" entries in the commit message footer. Using Signed-off-by to indicate committer sign-off is acceptable in addition to sign-off by the content author. If you have clear evidence that an author has signed-off on the content, then you can sign-off-by on their behalf. In this case, provide a link to the clear evidence (e.g. a link to the bug or ref) in the commit. HTH, Wayne On 07/03/2013 09:26 AM, Thanh Ha wrote: Hi Szymon, In this case this was a commit I created myself which is why there's no previous author/committer. It's a small subset of a different commit in the community Kepler stream [1]. So in this case I didn't reuse a commit but created a new one. In this case I'm not sure what's the right thing to do. It's easy for me to forge the Author if that's what we should do but the committer will always need to be changed due to the permissions currently configured for LTS which requires the committer be someone who has access to LTS. This is to ensure that we can track who pulled in a commit from the community side although setting a "Signed-off-by" entry would allow for this tracking as well. [1] http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=ac5a0fc4ac53fe300c6a74a013d2671988201f3c Thanh On 03/07/13 04:03 AM, Szymon Ptaszkiewicz wrote: Hi Thanh, Inspired by the recent switch to CLA and Signed-off-by I have a question: shouldn't this commit and all other commits that reuse an existing commit from a community branch preserve the actual author and/or committer? Or maybe we should have multiple Singed-off-by entries? I'm almost sure that this kind of information should be preserved when reusing commits between community repo branches, but I'm not sure if and how it applies to LTS repos. Thanks, Szymon -- Szymon Ptaszkiewicz Eclipse L3 Support Lead Rational Client Support IBM Software Group From: Thanh Ha <thanh.ha@xxxxxxxxxxx> To: lts-iwg@xxxxxxxxxxx Date: 2013-07-02 21:21 Subject: [lts-iwg] Running offline builds for LTS Sent by: lts-iwg-bounces@xxxxxxxxxxx Hi Everyone, I pushed a commit [1] for review to LTS. This commit would allow me to enable a completely offline Eclipse Platform build for LTS per discussion in bug 410075 so that in the future if any dependencies on the internet disappear the LTS Eclipse Platform build will continue to be build-able. We plan to achieve this by depending on the Maven Local Cache which stores all the artifacts the build needs after running a regular build and we plan to snapshot this cache and back it up in case it ever gets corrupt or needs replacing. Before this can happen though we need to apply a small patch [1] which removes a antrun script that does an external download an Eclipse Platform (Indigo) package. The use of this script was removed in the Kepler stream and but was never backported to Juno so my patch handles this backporting. Following the process for LTS I have submitted it for review. [1] https://lts.eclipse.org/r/#/c/37/ Thanh_______________________________________________ lts-iwg mailing list lts-iwg@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/lts-iwg _______________________________________________ lts-iwg mailing list lts-iwg@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/lts-iwg _______________________________________________ lts-iwg mailing list lts-iwg@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/lts-iwg -- Wayne Beaton Director of Open Source Projects, The Eclipse Foundation Learn about Eclipse Projects (Embedded image moved to file: pic45445.jpg)EclipseCon Europe 2013 _______________________________________________ lts-iwg mailing list lts-iwg@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/lts-iwg |