Re: [linuxtools-dev] TMF Hack-a-thon kickoff: file open dialog RFC

[Alexandre Montplaisir <alexmonthy@xxxxxxxxxxxx>]

On 13-12-12 10:55 AM, Aaron Spear wrote:
> Hi Michel, 
>
> I think that the "This is a file type that I handle" return value would be useful if it was not just boolean, but rather a rank of some sort. [...]

Hi Aaron,

The idea of rank, or "priority", is pretty good! It's so simple too, I
wonder why we didn't think about it. We have added a kind of
auto-detection already (see below), but to handle cases where a trace
can be both a "Generic CTF Trace" and a "LTTng Kernel Trace", we
resorted to funky reflection calls to check if one type is a subtype of
the other one, to filter the base type out. With integer priorities,
this becomes much more simple.

>
> I am sure I am not alone in being annoyed that I have to tell TMF what the trace is when I import it. It should be able to know much more often. 

Nope, you are not alone! And you will probably like the latest behavior
in master: the old clunky import wizard was replaced with two menu options:
- Open Trace File
- Open Trace Directory

Those options directly open a native file chooser dialog, or directory
chooser dialog, respectively, and upon selection of a file/directory, it
will automatically validate the trace type. If there are multiple
matches, it will ask the user to choose between the valid ones. If there
is only one, it will select that type automatically(!)

In the short-term, we might rename "Open Trace Directory" to "Open CTF
Trace", since out of the types we support, only CTF traces can be
directories.


Thanks for your input!
Alexandre