[linuxtools-dev] Hudson CI NAK'ing patches

[Alexandre Montplaisir <alexmonthy@xxxxxxxxxxxx>]

Hi all,

What would you think of making the Hudson-Gerrit plugin (a.k.a. Hudson
CI) giving "-1 Code Review" on Gerrit, instead of the current "-1
Verified"? The difference is that a committer can override a -1 CR when
giving it a +2, which allows pushing the patch anyway. When "-1
Verified" is given however, the patch is effectively veto'ed and cannot
be merged at all through Gerrit, unless you rebase it manually, or if
you push it directly through Git.

We do appreciate Hudson CI running the compilation/tests and reporting
the results. It's very helpful! However there are cases where the
failures are unrelated to the code being reviewed (unit test failures in
other projects, random brokage at Eclipse, etc.) and, imo, the human
should be able to ignore what Hudson says. Without having to resort to
dirty tricks like push-it-before-Hudson-runs or pushing through Git.

I'm not sure how to change this, but CDT has their Gerrit set up this
way, if I'm not mistaken.

What do you think?


Cheers,
Alexandre