Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [linuxtools-dev] Use Gerrit?

On Fri, 2012-01-27 at 18:00 -0500, Andrew Overholt wrote:
> Yes, one can always give their own code a +2 for emergency fixes.  But
> it's sort of in the spirit of code review to have others review all
> changes as it spreads knowledge and generally improves code :) 

What's more, commiters should have also access to so called direct push,
where commits go directly to master. 

It is believed that code reviews for commits sized < 300 LOC discover
60-70% of bugs, but that ratio falls very quickly if the patches are
bigger, so kind of a coding discipline will be required.

+1 for using gerrit.
-- 
Krzysztof Daniel <kdaniel@xxxxxxxxxx>
Red Hat



Back to the top