[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [linuxtools-dev] Use Gerrit?
|
On Sat, Jan 28, 2012 at 12:43 AM, Jeff Johnston <jjohnstn@xxxxxxxxxx> wrote:
> On 01/27/2012 04:50 PM, Andrew Overholt wrote:
>>
>> Hi,
>>
>> Gerrit ([1], web-based code review system) is almost ready for usage by
>> all eclipse.org projects [2].
>>
>> How do Linux Tools contributors and committers feel about using it for
>> Linux Tools?
>>
>> Andrew
>>
>> [1]
>> http://code.google.com/p/gerrit/
>> Eclipse instance: https://git.eclipse.org/r
>>
>> [2]
>> https://bugs.eclipse.org/bugs/show_bug.cgi?id=283749
>> _______________________________________________
>> linuxtools-dev mailing list
>> linuxtools-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/linuxtools-dev
>
>
> I like the idea of using it for bugzilla submissions.
>
> Assuming we are appointed approver/verifiers for our components of
> expertise, would we be able to push our own fixes quickly? For example, it
> kind of gets in the way if I am forced to review Alex's changes to the rpm
> editor where he is the expert.
Jeff, I can assure you that one can always catch smth in my patches
(and everybody's patches TBH ) . :)
And Linux Tools really suffer from people being focused on one small
piece of the code. For me this is the reason to not have common
library - e.g. for calling native tools, getting the output/error log,
giving us a way to cancel it and etc. Every subproject implements it
in its
own more or less broken way - buggy or not being able to cancel or
losing output or .... We (Linux Tools contributors) need to act more
like a team and less like a bunch of individuals that just happened to
share the same code repository. I really thing using code review tool
is worth it if it can even slightly improve this aspect of the project
despite the possibility to slow us a bit.
Alex
>
> My other question is what happens with build changes. For example, for a
> release we usually have to touch all pom.xml files in the different
> components. Making all component owners approve/verify seems a tad
> unnecessary and dangerous for emergency build fixes. Can Hudson be the
> verifier for these changes (i.e. ensuring the build and tests succeed)?
>
> -- Jeff J.
>
> _______________________________________________
> linuxtools-dev mailing list
> linuxtools-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/linuxtools-dev
