Re: [linuxtools-dev] [PATCH] linuxtools, oprofile: Improve error message

[Andrew Overholt <overholt@xxxxxxxxxx>]

Thanks for taking this to bugzilla, Corey.

Andrew

* Corey Ashford <cjashfor@xxxxxxxxxxxxxxxxxx> [2011-03-29 17:52]:
> Add extra verbiage to give a clue as to what might have gone wrong if
> opcontrol returns a non-zero exit status, particularly for the case when
> /usr/bin/consolehelper is not installed on the system (e.g. consolehelper
> is not in the SuSE distro).
> 
> Signed-off-by: Corey Ashford <cjashfor@xxxxxxxxxxxxxxxxxx>
> ---
>  .../linuxtools/oprofile/core/oprofile.properties   |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/oprofile/core/oprofile.properties b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/oprofile/core/oprofile.properties
> index d5533d6..d2ac0e1 100644
> --- a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/oprofile/core/oprofile.properties
> +++ b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/oprofile/core/oprofile.properties
> @@ -18,7 +18,7 @@ oprofileInit.error.dialog.title=Error initializing OProfile
>  oprofileInit.error.dialog.message=FATAL: The OProfile kernel module could not be loaded.
>  
>  opcontrolRun.error.statusMessage=Error during run of opcontrol
> -opcontrolNonZeroExitCode.error.statusMessage=Exit code of opcontrol indicates failure
> +opcontrolNonZeroExitCode.error.statusMessage=Exit code of opcontrol indicates failure.\nIf this system does not have /usr/bin/consolehelper, make sure you have added\nthe following line to /etc/sudoers:\n<username> ALL=(ALL) NOPASSWD: <path to opcontrol, e.g. /usr/bin/opcontrol>
>  
>  opcontrolProvider.error.statusMessage=Could not find an OpcontrolProvider, or no opcontrol binary exists.\n\nPlease ensure you have run the install script as the root user. The install script will be in the org.eclipse.linuxtools.oprofile.core plugin, which may be located in one of a few places. You can locate it with the following command (type in a terminal):\n\nfind <~/.eclipse OR the location from which you're running eclipse> \ \n-name 'org.eclipse.linuxtools.oprofile.core_*'\n\nWhen you have found the location of the plugin, as root, run the install script contained therein:\n\ncd <path to org.eclipse.linuxtools.oprofile.core>/natives/linux/scripts\nsh install.sh\n\nYou may need to set the script as executable before running this command; do this with:\n\nchmod u+x install.sh
>  
> -- 
> 1.7.0.4
>