Re: [jgit-dev] HttpClientConnection.getHeaderFields to support multiple

[David Pursehouse <david.pursehouse@xxxxxxxxx>]

On Tue, Jun 19, 2018 at 10:38 AM Gabriel Couto <gmcouto@xxxxxxxxx> wrote:

Hello dear JGit devs,

I have come here to bring a patch for an old bug that might have never been reported.

We might see in the internet it is very hard to get JGit to connect to a TFS server, but today I have found the reason.

It is because of HttpClientConnection.getHeaderFields. If a server replies with multiple WWW-Authenticate, it will consider only the last value read.

Except the correct behavior is to provide a list of all the values if same header key.

Because of this bug JGit will not even try other authentication methods if NTLM is the last one in the response header.

I have patched this with a Pull Request, that I kindly ask to be accepted:

https://github.com/eclipse/jgit/pull/68

The jgit project on github is only a mirror of the canonical project on eclipse.org [1] and pull requests are not accepted.

Please send the patch for review on gerrit [2] instead, as described in the contribution guide [3].

[1] git://git.eclipse.org/gitroot/jgit/jgit.git

[2] https://git.eclipse.org/r/

[3] https://github.com/eclipse/jgit/blob/master/CONTRIBUTING.md

 

 

I also have workarounds provided if anyone is facing a similar issue, and can't wait for the fix:

https://stackoverflow.com/a/50919290/697399

Regards,

Gabriel Couto

_______________________________________________
jgit-dev mailing list
jgit-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jgit-dev