Re: [jetty-dev] mechanical sympathy in netty-4

[Viktor Szathmary <phraktle@xxxxxxxxx>]

Hi Simone,

On Wednesday, October 16, 2013 at 4:04 PM, Simone Bordet wrote:

Some ?

I think we are using pooled ByteBuffer everywhere we can.

Are you referring to a particular place in the code ?

You are absolutely right of course. I'm still just getting familiar w/ the Jetty design / codebase :)

I am not sure I understand this one.

Request.getReader() does not do any buffer allocations ?

It only does so implicitly:

InputStreamReader allocates a HeapByteBuffer:

org.eclipse.jetty.server.Request.getReader()

java.io.InputStreamReader.<init>(InputStream, String)

sun.nio.cs.StreamDecoder.forInputStreamReader(InputStream, Object, String)

sun.nio.cs.StreamDecoder.<init>(InputStream, Object, Charset)

sun.nio.cs.StreamDecoder.<init>(InputStream, Object, CharsetDecoder)

java.nio.ByteBuffer.allocate(int)

java.nio.HeapByteBuffer.<init>(int, int)

also, the constructed BufferedReader allocates a new char[]:

org.eclipse.jetty.server.Request.getReader()

org.eclipse.jetty.server.Request$1.<init>(Request, Reader, ServletInputStream)

java.io.BufferedReader.<init>(Reader)

java.io.BufferedReader.<init>(Reader, int)

Regards,

  Viktor