Thanks for the clarification, Markus. Still I think the way to get high quality patches in the first place is constant reviews, which committers
have some duty to conduct.
To be even more transparent, please consider writing comments about your review priority in the respective bug or Gerrit change, so that we don't
even need to lead discussions like this.
Christian
From:
<jdt-ui-dev-bounces@xxxxxxxxxxx> on behalf of Markus Keller <markus_keller@xxxxxxxxxx>
Reply-To: "Eclipse JDT UI developers list." <jdt-ui-dev@xxxxxxxxxxx>
Date: Thursday, 17 November 2016 at 15:11
To: "Eclipse JDT UI developers list." <jdt-ui-dev@xxxxxxxxxxx>
Subject: Re: [jdt-ui-dev] SubMonitor adoption in JDT UI
Sorry, I should have made it more clear that my response was specific to this request and this contributor.
A big amount of my work time is wasted on reviewing and reverting such changes. Instead of silently ignoring this request, I wanted to explain why this bug wasn't given priority.
We do welcome high-quality contributions.
Markus
From: "Markov, Veselin" <Markov@xxxxxxxxx>
To: "Eclipse JDT UI developers list." <jdt-ui-dev@xxxxxxxxxxx>
Date: 2016-11-17 14:44
Subject: Re: [jdt-ui-dev] SubMonitor adoption in JDT UI
Sent by: jdt-ui-dev-bounces@xxxxxxxxxxx
Hello Markus,
If I were you I’d give a second thought before answering a review request from a contributor.
You just accused contributors of being incompetent and lazy and said there is no point of contributing to eclipse because the changes won’t be reviewed anyway.
Mit freundlichen Grüßen / Best regards
Veselin Markov
|
Systemhaus für Sicherheitstechnik und Softwareentwicklung
|
|
Entwicklungsleiter
|
|
|
GEMTEC GmbH, Am Möllenberg 37, 15713 Königs Wusterhausen
|
Homepage: www.gemtec.eu|
www.wotanex.de
Sitz der Gesellschaft: Königs Wusterhausen OT Niederlehme
Geschäftsführer: Nils Burschik, Jan Burschik, Jens Krönert, Sven Lauritsen
Handelsregister: Amtsgericht Cottbus HRB 9452 CB
___________________________________________________________
Diese E-Mail (inklusive aller Anhänge) enthält vertrauliche und/oder rechtlich geschützte Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese
E-Mail. Das unerlaubte Lesen, Kopieren sowie die unbefugte Weitergabe, aber auch das Verwenden oder der Transfer von Informationen aus dieser E-Mail ist unter Bezug auf die aktuelle Rechtsprechung nicht gestattet. Bitte beachten Sie, dass E-Mails an die persönliche
E-Mail-Adresse des Absenders nicht regelmäßig kontrolliert werden und daher E-Mails für fristgebundene Inhalte nicht geeignet sind. Wir weisen ausdrücklich darauf hin, dass zum rechtsgültigen Abschluss von Verträgen ausschließlich Dokumente geeignet sind,
die die rechtsgültigen Unterschriften der Vertretungsberechtigten unseres Unternehmens enthalten. Vielen Dank.
Von: jdt-ui-dev-bounces@xxxxxxxxxxx [mailto:jdt-ui-dev-bounces@xxxxxxxxxxx]
Im Auftrag von Markus Keller
Gesendet: Donnerstag, 17. November 2016 12:36
An: Eclipse JDT UI developers list.
Betreff: Re: [jdt-ui-dev] SubMonitor adoption in JDT UI
Such "fairly simple" changes break things in 80% of the cases, because the contributor didn't give enough attention to details.
We don't have the resources or motivation to do the necessary thorough review for such contributions, given that we don't expect functional benefits for users.
Markus,
From: Stefan Xenos <sxenos@xxxxxxxxxx>
To: jdt-ui-dev@xxxxxxxxxxx, Lars Vogel <lars.vogel@xxxxxxxxxxx>
Date: 2016-11-15 19:42
Subject: [jdt-ui-dev] SubMonitor adoption in JDT UI
Sent by: jdt-ui-dev-bounces@xxxxxxxxxxx
Hi!
Lars has a number of outstanding reviews in the JDT UI project related to adoption of SubMonitor. They're fairly simple and have been sitting in the review queue for over a year.
It would be helpful if someone could look at these reviews, since further adoption of SubMonitor would let me run the automated analysis tools to look for progress monitoring bugs in JDT UI.
https://git.eclipse.org/r/#/c/57921/
https://git.eclipse.org/r/#/c/57920/
https://git.eclipse.org/r/#/c/57875/
- Stefan_______________________________________________
jdt-ui-dev mailing list
jdt-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jdt-ui-dev
_______________________________________________
jdt-ui-dev mailing list
jdt-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jdt-ui-dev
