Re: [jdt-ui-dev] Always need for bug # in commit msg?

[Daniel Megert <daniel_megert@xxxxxxxxxx>]

Hi Robin

Nice to hear that you want to contribute!

In general we do want a bug report,
but for trivial changes a Gerrit change is good enough. One thing to keep
in mind when fixing formatting, coding conventions or whitespace, is whether
the change really makes things better, because such changes always make
it harder to track the history of a file later.

Dani



From:      
 Robin Henricsson <robinhenricsson@xxxxxxxxx>
To:      
 jdt-ui-dev@xxxxxxxxxxx
Date:      
 21.11.2014 21:12
Subject:    
   [jdt-ui-dev]
Always need for bug # in commit msg?
Sent by:    
   jdt-ui-dev-bounces@xxxxxxxxxxx

---

I've been using Eclipse for Java development
for a couple of years now, and may have found a JDT issue on BugZilla
that I would like to fix, thereby contributing to the great product
I use on a daily basis.

The thing is, though, that I've never worked
on an open source project before and so I would like to start off
by committing something a bit smaller and easier. I have found some
code that I believe does not quite follow the code convention and
thought of updating it.

The contribution wiki page (http://wiki.eclipse.org/JDT_UI/How_to_Contribute) says
that I need to include the bug number in the commit message. Do I need to
file a bug report for the code convention deviations or can I just go ahead
and fix them and then push to Gerrit?

Thanks a lot in advance, I look forward to
getting into this.
Regards
Robin

-- 
Robin Henricsson
RobinHenricsson@xxxxxxxxx
0734292332_______________________________________________
jdt-ui-dev mailing list
jdt-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/jdt-ui-dev