[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [jdt-dev] Fwd: [eclipse-jdt/eclipse.jdt.core] Run failed: Publish Unit Test Results - master (92fba49)
|
Hi Stephan,
Long story short: https://github.com/eclipse-jdt/eclipse.jdt.core/pull/1389
For the details:
1) the ci.yml workflow only runs on a push to any branch ( line 8 ) but
it does not run on a pull request, therefore you only see it if anything
is actually merged to the repository or pushed to a branch on the
repository, I can't tell if it was intentional so I left it unchanged
2) the unit-tests.yml is triggered by the ci.yml afterwards but has
missing some important things
2.1) it needs to upload the event file so the workflow can gather some
additional context information
2.2) it needs to be uploaded the test-results produced by ci.yml
3) to prevent projects from doing all this tedious work there is
actually a so called "unified workflow" see for example [1] which is
triggered for PR and PUSHES and perform the "usual" work recommended for
a platform project
4) I already tried to establish that here [2] but did not get much
support in resolving some of the test-configuration issues and instead
it ended in a general rant about if/how to handle test failures so it is
somehow abandoned.
In general I can help with any build issues or details about github
workflows, but if people just constantly IGNORE issues and just feel
annoyed it hard to improve the situation, so if you see any further
issues just open a ticket on github and mention me (there are just to
many malinglists and github projects to watch them all).
About the emails, I think the one who merges the PR will receive the
mail about failing workflows as a result of that mail as it usually
means "you have merged something but some checks for this commit failed"
so if yo merge many things you of course getting this mail probably more
often.
HTH
Christoph
[1]
https://github.com/eclipse-platform/eclipse.platform/blob/master/.github/workflows/ci.yml
[2] https://github.com/eclipse-jdt/eclipse.jdt.debug/pull/237
Am 19.09.23 um 00:36 schrieb Stephan Herrmann via jdt-dev:
Let's do the forensics:
The workflow file unit-tests.yml
<https://github.com/eclipse-jdt/eclipse.jdt.core/blob/master/.github/workflows/unit-tests.yml> was created on 2023-04-17 and hasn't been changed since.
The first of those (constantly failing) workflows ran on 2023-07-28.
That's when Mickael started to work on ci.yml, first in a PR, then when
that was merged every commit to master (i.e., every merge of a PR)
started triggering both these workflows. So unit-tests.yml only became
effective when ci.yml was added.
Sometimes, the same commit triggers more than one run of the workflow,
e.g.:
#25
https://github.com/eclipse-jdt/eclipse.jdt.core/actions/runs/6195748998
#24
https://github.com/eclipse-jdt/eclipse.jdt.core/actions/runs/6195338053
Wait, when you drill into one of the failures (across several levels)
than you'll see:
Traceback (most recent call last):
File "/action/publish_test_results.py", line 529, in <module>
settings = get_settings(options, gha)
File "/action/publish_test_results.py", line 389, in get_settings
with open(event, 'rt', encoding='utf-8') as f:
FileNotFoundError: [Errno 2] No such file or directory: 'artifacts/Event
File/event.json'
Does anyone know about these things and you to fix or at least silence it?
BTW, Are others receiving those emails, too?
On 18.09.23 23:25, Roland Grunberg wrote:
On Mon, 2023-09-18 at 21:28 +0200, Stephan Herrmann via jdt-dev wrote:
What is a mail like this trying to tell me and where do I get
additional
information, on what failed and where?
Yes, I can recognize the commit ID, which I recently merged, after
github signalled all checks are green.
When I look at
https://github.com/eclipse-jdt/eclipse.jdt.core/actions/runs/6216200378
, I see
https://github.com/eclipse-jdt/eclipse.jdt.core/commit/92fba491e94bf1c3dc79f0014aedb3e75896a9ac
as the commit associated with that. When looking at the checks for the
commit, they all seem to pass, so I'd guess it's not configured to run
on a pull/push to the repo. Looking at :
https://github.com/eclipse-jdt/eclipse.jdt.core/actions/workflows/unit-tests.yml
https://github.com/eclipse-jdt/eclipse.jdt.core/blob/master/.github/workflows/unit-tests.yml
it hasn't ever passed so maybe it just hasn't been configured correctly
or the JDT Core tests aren't publishing something that the job requires
to properly report the results.
_______________________________________________
jdt-dev mailing list
jdt-dev@xxxxxxxxxxx
To unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev
