Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jdt-dev] Gerrit builds failing

On 08/08/2014 06:33 PM, Markus Keller wrote:
> Also, I would suggest that even people who are committer on the project use Gerrit, and leverage this pre-merge validation. It will help to detect issues early. in there context so we could fix them more easily.

Gerrit [...] doesn't add any benefit.
I'm not really sure about that (and to be more explicit, I'm sure of the contrary ;). JDT tests used to work well with Maven surefire, and they are currently failing. If the change causing the failure would have been pushed and validated by Gerrit, it would be way easier to find the cause of these failures and to avoid those red balls on Jenkins.
The difference is that you probably don't run surefire tests locally, so your local build doesn't guarantee fully working state.
--
Mickael Istria
Eclipse developer at JBoss, by Red Hat
My blog - My Tweets

Back to the top