Re: [incquery-dev] PSystem/Builder refactor - part 2

[Ujhelyi Zoltán <ujhelyiz@xxxxxxxxxx>]

Hi,

thanks again for the detailed review. I tried to address all your issues in Gerrit (the Hudson error were caused by an unintended change and plain stupidity on my behalf - sorry for spamming).

About Eclipse/UI independency: the patternlanguage.emf project should be independent of the Eclipse runtime and of course the Eclipse UI - it can be used in eclipse-less environments, and this is true for all their dependencies (if not, it is a bug). In other words, I don't think a separate project for this logic is necessary, but correct me if this is not true.

Cheers,
Zoli
-- Zoltán Ujhelyi
https://www.inf.mit.bme.hu/en/members/ujhelyiz

Fault Tolerant Systems Research Group
Budapest University of Technology and Economics

On 2014.01.26., at 20:02, Istvan Rath <rath@xxxxxxxxxx> wrote:

> Zoli,  
> 
> thanks for the great work. I think I will wait with the detailed tests until you get the cleaner up to speed.
> 
> I have added some comments to the code in Gerrit. Some of the comments need further attention, so please take a look.
> 
> A final question:
> 
> On Saturday 25 January 2014 at 13:43, Ujhelyi Zoltán wrote:
> 
>> * All PSystem building code is moved into patternlanguage.emf project (they should still be eclipse and UI independent)
> 
> 
> If something is Eclipse and UI independent, isn’t it better moved to a separate project which is declared to be independent of Eclipse and the UI?
> 
> cheers
> Istvan
> 
> 
> --
> Istvan RATH, PhD
> Research fellow
> Budapest University of Technology and Economics
> 
> Fault Tolerant Systems Research Group
> 
> _______________________________________________
> incquery-dev mailing list
> incquery-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/incquery-dev