[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [imp-dev] Heads up on pdb.values inputstreams and outputstreams

HI Anya,

Thanks for the warning! I forgot to add some files, and to remove some
too. Mixup between commandline and Eclipse interface for SVN :(

I also reactivated the tests you mention and they do pass now.

Cheers!

Jurgen

On Sun, Jan 8, 2012 at 4:29 AM, Anya Helene Bagge <anya@xxxxxxxxx> wrote:
> On 01/07/2012 10:26 PM, Jurgen Vinju wrote:
>>
>> Hi Imps,
>>
>> There has been some work to make pdb.values unicode friendly. Some
>> methods have been added to IString to hide complexity about
>> codepoints, UTF16 encodings and such.
>
>
> Hmm, looks like you might have forgotten to add some of the files. At least,
> it doesn't compile at all now (missing AbstractTextReader, amongst other
> things).
>
> BTW, while you're at it, can you apply the following patch to
> org.eclipse.imp.pdb.test? It adds a test that was disabled because of some
> bugs in the IO implementation that have now been fixed (yes, bad choice to
> disable it in the first place...).
>
> -anya
>
> Index: src/org/eclipse/imp/pdb/test/BaseTestRandomValues.java
> ===================================================================
> --- src/org/eclipse/imp/pdb/test/BaseTestRandomValues.java      (revision
> 22948)
> +++ src/org/eclipse/imp/pdb/test/BaseTestRandomValues.java      (working
> copy)
> @@ -150,11 +150,9 @@
>        }
>
>        private void ioHelper1(String io, IValueReader reader, IValueWriter
> writer) throws IOException {
> -               // TODO: integer I/O is broken in the reference
> implementation
> -
>  if(!getClass().getPackage().getName().equals("org.eclipse.imp.pdb.test.reference"))
> -                       ioHelper2(io + " Integers", reader, writer, new
> DataGenerator(generator, INumber.class, intTestSet, new
> RandomIntegerGenerator(vf)));
> +               ioHelper2(io + " Integers", reader, writer, new
> DataGenerator(generator, INumber.class, intTestSet, new
> RandomIntegerGenerator(vf)));
>                ioHelper2(io + " Rationals", reader, writer, new
> DataGenerator(generator, INumber.class, ratTestSet, new
> RandomRationalGenerator(vf)));
> -                       ioHelper2(io + " Reals", reader, writer, new
> DataGenerator(generator, INumber.class, realTestSet, new
> RandomRealGenerator(vf)));
> +               ioHelper2(io + " Reals", reader, writer, new
> DataGenerator(generator, INumber.class, realTestSet, new
> RandomRealGenerator(vf)));
>        }
>
>
>
>
>



-- 
Jurgen Vinju
- Centrum Wiskunde & Informatica - SEN1
- INRIA Lille - ATEAMS
- Universiteit van Amsterdam

  www: http://jurgen.vinju.org,
http://www.rascal-mpl.org,http://twitter.com/jurgenvinju
skype: jurgen.vinju