Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ice-dev] [ice-build] [eclipse/ice] e14b71: Fixing new Generate YAML action bug.
My feeling is that even this solution isn't ideal. For example, much of what is below line 81 is very specific MOOSELauncher information that violates encapsulation because it requires secret knowledge to execute, i.e. - knowledge that execList.add("Generate YAML/action syntax") causes behavior not obvious from the API.
We don't need to fix this now, but someone needs to open a bug so that we fix it over the summer. One way to fix this it to create a subclass of MOOSELauncher that publishes itself as a separate Item and knows the secret sauce. The other way to do it is through the IUtility interface that I mentioned when we first created this action that would encapsulate all of this knowledge in some operations from the interface implemented by the MOOSELauncher.
But, as I said, we'll look at it further over the summer. It is sufficient now that it is out of the JobLauncher. 

Jay

On 04/24/2015 11:26 AM, McCaskey, Alex wrote:

As I understand it, Anna added a check in the fillDataMap method to see if the user had actually provided a file for any of the FileEntries in the Files DataComponent. I think this is fine, we don’t want to launch with a malformed list of files. So I think the JobLauncher as it stood before the reverted commit was fine.

Her fix was to essentially only do this check if the Executable DataComponent didn’t have its Entry set to Generate YAML, which is bad on a number of levels, first of which is that the Exec DataComponent is a SuiteLauncher thing and not a JobLauncher thing.

So my fix was pretty simple: if the JobLauncher loops over File Entries in its File DataComponent to check their validity, and I’m creating a MOOSELauncher in the YAML Handler (an action that needs no files), then just clear the Entries from the File DataComponent. Then when the JobLauncher gets to that file check loop, it simply skips it because there are not files to loop over.

Alex



On Apr 24, 2015, at 11:15 AM, Jay Jay Billings <jayjaybillings@xxxxxxxxx<mailto:jayjaybillings@xxxxxxxxx>> wrote:

Alex,

Can you write a bit please on how this issue relates to Anna's original bug and her fix? I would like to know. It would be better still if you could write it up in an associated ticket on Bugzilla.

Thanks,
Jay

On Fri, Apr 24, 2015 at 10:03 AM, GitHub <noreply@xxxxxxxxxx<mailto:noreply@xxxxxxxxxx>> wrote:
   Branch: refs/heads/master
   Home:   https://github.com/eclipse/ice
   Commit: e14b713e073e6fc577b5d80ed97398b9492f4e84
       https://github.com/eclipse/ice/commit/e14b713e073e6fc577b5d80ed97398b9492f4e84
   Author: Alex McCaskey <mccaskeyaj@xxxxxxxx<mailto:mccaskeyaj@xxxxxxxx>>
   Date:   2015-04-24 (Fri, 24 Apr 2015)

   Changed paths:
     M src/org.eclipse.ice.client.widgets.moose/src/org/eclipse/ice/client/widgets/moose/wizards/GenerateYAMLHandler.java

   Log Message:
   -----------
   Fixing new Generate YAML action bug.

The JobLauncher now throws an error if any of the file entries are empty
or null. This was put in before checking that the generate yaml action
worked, which it doesn't because it uses no files.

Since this action does not need any files, I'm just clearing them from
the file DataComponent in the MooseLauncher Form.

Signed-off-by: Alex McCaskey <mccaskeyaj@xxxxxxxx<mailto:mccaskeyaj@xxxxxxxx>>



_______________________________________________
ice-build mailing list
ice-build@xxxxxxxxxxx<mailto:ice-build@xxxxxxxxxxx>
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ice-build




--
Jay Jay Billings
Oak Ridge National Laboratory
Twitter Handle: @jayjaybillings
_______________________________________________
ice-dev mailing list
ice-dev@xxxxxxxxxxx<mailto:ice-dev@xxxxxxxxxxx>
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ice-dev

Alex McCaskey
ORNL Computer Science Research
mccaskeyaj@xxxxxxxx<mailto:mccaskeyaj@xxxxxxxx>
(865) 574-8715



_______________________________________________
ice-dev mailing list
ice-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ice-dev



--
Jay Jay Billings
Oak Ridge National Laboratory
(865) 241-6308
Twitter Handle: @jayjaybillings

I only check email at 8:30, 12:30 and 16:30 every day. Please call me or send
me a tweet if your message is urgent and I will take a look.

Back to the top