[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [iam-dev] SVN properties.
|
So... can you propose the default settings for IAM? Should we adopt maven's?
Please update the wiki as you suggested and then everyone can propose enhancements, if needed (although from my ignorant point of view, it looks quite complete).
2008/12/4 Joakim Erdfelt
<joakim.erdfelt@xxxxxxxxx>
http://svnbook.red-bean.com/en/1.5/svn.ref.properties.html
To me, the most important property is actually svn:eol-style, as that is what controls cross-developer merging properly.
If developer A uses Windows and developer B uses Linux, then the likelyhood of full file diff commits between those 2 developers is high. However, if you simply set the svn:eol-style to native, then you eliminate that full file diff commit syndrome. (This occurs because the diff between a java source file with Windows EOL and Linux EOL is actually the entire file.)
Having sane diffs between versions is ideal for tracking changes.
I also like having svn:keywords set to Id for java source, as that allows the generated javadoc to have the subversion info contained within the @version $Id$ line show up.
When working with executable files, such as *.bat and *.sh setting the svn:executable flag is important so that everyone gets that set properly, esp important when archiving content into zip files (tarballs, jars, wars, etc).
These properties can be set manually, or turned on in $HOME/.subversion/config
enable-auto-props=yes
Many apache projects have their own settings.
http://www.google.com/search?hl=en&q=svn+enable-auto-props+site%3Aapache.org
Maven even has its own set - http://maven.apache.org/developers/svn-eol-style.txt
Oddly, eclipse.org has no such recommendations.
- Joakim Erdfelt
2008/12/3 Abel Muiño Vizcaino
<amuino@xxxxxxxxx>
I was not aware of any svn properties being explicitly set. I guess that those have been set by different svn clients (maybe there is buggy one somewhere). I don't even know what some of them are for or their format (I must admit that I only use svn:ignore).
What's the impact/problems of the current situation?
For me it is ok to fix them, but we might need to keep an eye on it in case the bad properties come back.
El 04/12/2008, a las 1:02, Joakim Erdfelt escribió:
I just stumbled into some bad SVN properties for a few java files in the wtp.core project.
So I thought I'd be nice and fix them.
However, I decided to see if the problem exists elsewhere in IAM and just fix them there too.
But this produced a large potential commit. Which I have not committed.
Example of bad properties.
Example of cleaned up properties. (note, the quotes around Author Date Id Revision are not valid)
[joakim@monolith trunk]$ svn proplist -v plugins/maven/jdt/core/src/main/java/org/eclipse/iam/jdt/core/MavenClasspathHelper.java
Properties on 'plugins/maven/jdt/core/src/main/java/org/eclipse/iam/jdt/core/MavenClasspathHelper.java':
svn:mime-type : text/plain
svn:keywords : Author Date Id Revision
svn:mergeinfo :
svn:eol-style : native
There are many more files that don't even have their svn:eol-style, and I just checked the java source files.
When I check the total number of changes i see ...
[joakim@monolith trunk]$ svn status | grep -E "^.M" | wc -l
628
Which is 628 files with svn property modifications, and ...
[joakim@monolith trunk]$ svn status | grep -E "^MM" | wc -l
310
310 files with file modifications (that arise from specifying an svn:eol-style that causes the file to be updated for unix line endings on my system)
I can make this change, but I would rather get the conversation going about this first.
I also created a bug (
http://tinyurl.com/IAM-bugs ) at
https://bugs.eclipse.org/257444 - Joakim
iam-dev mailing list
iam-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/iam-dev
_______________________________________________
iam-dev mailing list
iam-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/iam-dev
_______________________________________________
iam-dev mailing list
iam-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/iam-dev
--
Abel Muiño -
http://ramblingabout.wordpress.com/
