Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [iam-dev] Exception Handler Extension Point

Comments below.

2008/12/4 Abel Muiño Vizcaino <amuino@xxxxxxxxx>
I like the concept, but I have some concerns about it. 

There's something strange on adding extension points for managing core exceptions. What if several plug-ins declare handlers for the same exception?

I imagine that they would fire at the order eclipse gave us.
 
Also I have the feeling that we need to address this at a higher level and not have extenders know about maven internals (exceptions, in this case).

Make sense.
 
Finally, this wizard would interrupt the user flow... I think that the right way would be to add an error marker and have another plug-in contribute a quick-fix for it. 

That would be a better idea. I'll try to find a solution in that direction.
 
Would it be possible? It looks like that's the "eclipse way".

El 03/12/2008, a las 18:49, Erle Mantos escribió:

Hi Guys,

Just wanna know what you think.

While investigating Issue 98 ( http://code.google.com/p/q4e/issues/detail?id=98 ) in our google code issue
tracker, I came across a need for an exception handler that must launch a wizard. Now, this will introduce
a circular dependency if we write the exception handling code in the core, and no assurance for the exception
handling code to be loaded if we place it in the wizard plugin ( or any other IAM plugin, except if we force that
plugin to be NOT lazy loading, which is bad practice ).

The cleanest solution I found was to create an extension point for exception handlers. This means any plugin
can declare handlers for exceptions, without core knowing about it ( avoiding circular dependency , and its just
good design ).

Any comments ? If not, I'll assume this approach is good.

--
Cheers,

Erle Czar Mantos
Software Engineer | Exist Global | 412-1155 | Skype: emantos | www.exist.com | Innovation Delivered
_______________________________________________
iam-dev mailing list
iam-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/iam-dev


_______________________________________________
iam-dev mailing list
iam-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/iam-dev




--
Cheers,

Erle Czar Mantos
Software Engineer | Exist Global | 412-1155 | Skype: emantos | www.exist.com | Innovation Delivered

Back to the top