Re: [henshin-dev] Bug in NodeTypeParser?

[Stefan Jurack <henshin.stj@xxxxxxxxx>]

Am 13.09.2011 11:18, schrieb Christian Krause:
> Hi,
> I found this code in findMappedNodes() in the NodeTypeParser:
>
> if (isLhsPart)
>    originNodes.add(mapping.getOrigin());
> else
>    imageNodes.add(mapping.getOrigin());
>
> This looks a bit weird, but maybe it is correct: please just check if
> it is really supposed to be like this.
I'll check this immediately.
>
> Felix, you added the method parseName(String nodeString) and an extra
> RegExp in NodeTypeParserHelper. I think it would be better if the
> existing method and pattern would be modified instead of adding new
> versions of it(?). Also, please provide proper SVN comments the next
> time.
>
I already talked about that with him since I had the same opinion.
Actually I am changing the implementation exactly the way you mentioned
above. ;-)

Stefan

> Ciao,
> Christian
>
>
> _______________________________________________
> henshin-dev mailing list
> henshin-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/henshin-dev

Attachment: signature.asc
Description: OpenPGP digital signature