Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[henshin-dev] Bug in NodeTypeParser?

Hi,
I found this code in findMappedNodes() in the NodeTypeParser:

if (isLhsPart)
   originNodes.add(mapping.getOrigin());
else
   imageNodes.add(mapping.getOrigin());

This looks a bit weird, but maybe it is correct: please just check if it is really supposed to be like this.

Felix, you added the method parseName(String nodeString) and an extra RegExp in NodeTypeParserHelper. I think it would be better if the existing method and pattern would be modified instead of adding new versions of it(?). Also, please provide proper SVN comments the next time.

Ciao,
Christian




Back to the top