Re: [gmf-dev] Bug #371888 - Refactoring to support ComboDirectEditManage

[Aurélien Pupier <aurelien.pupier@xxxxxxxxxxxxxx>]

Hi,

The number of lines modified is above 250. But a lot of lines have just move. Do we need to count them?

Who is the contributor?
Michael you open the bug but it is Svyatoslav Kovalsky that provided the patchs. He is not a committer, isn't it?

I think that I need to open a CQ. Anthony can you confirm it? or do you think that I just need to put IP flag?

Regards,

2012/2/17 Michael Golubev <golubev@xxxxxxxxxxxx>

Aurelien, Anthony

Could you please take a look at the Bugzilla #371888 [1] and review the proposed patches for GMF Runtime. 

The one of the patches there [2] contains the proposed new class ComboCellEditorEx which is actually extending the 

@noextend ComboBoxCellEditor from jface. 

If this is not acceptable, please ignore this part, our main need is the refactoring of existing DirectEditManager'-related code, 

localized in the main patch [3]. 

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=371888
[2] https://bugs.eclipse.org/bugs/attachment.cgi?id=211191

[3] https://bugs.eclipse.org/bugs/attachment.cgi?id=211190

 Regards,

-- 

Michael "Borlander" Golubev
Eclipse Committer (GMF, UML2Tools)
at Montages Think Tank, Prague, Czech Republic

Montages AG
Stampfenbachstr. 48, CH-8006 Zürich

tel:    +41 44 260 75 57

mob: +420 602 483 463

_______________________________________________
gmf-dev mailing list
gmf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/gmf-dev

--

Aurelien Pupier
R&D Engineer, BOS Studio Developer
QA Project Leader

email : aurelien.pupier@xxxxxxxxxxxxxx

This message and any attachment (the "message") is intended solely for the addressees and is confidential. If you receive this message by mistake, please delete it and notify the sender immediately. Any use not in accordance with its purpose, any out-spread or disclosure, either as a whole or partially, is prohibited except with formal approval. Internet cannot guarantee the integrity of this message, therefore BonitaSoft will not be liable for the message if modified.