Re: [gmf-dev] Bug #371888 - Refactoring to support ComboDirectEditManage

[Michael Golubev <golubev@xxxxxxxxxxxx>]

Hello,

The number of lines modified is above 250. But a lot of lines have just move. Do we need to count them?

Sorry, no idea, never heard about LOCs counting for patches at all. 

Can you share some links to LOC-related policies I missed? 

Who is the contributor?
Michael you open the bug but it is Svyatoslav Kovalsky that provided the patchs. He is not a committer, isn't it?

Svyatoslav Kovalsky is the actual contributor. 

I hope he will be a committer soon, but for GMF-T and definitely not for GMF Runtime. 

I think that I need to open a CQ. Anthony can you confirm it? or do you think that I just need to put IP flag?

To my understanding IP Log flag for the patch should be enough. 

Regards, 

-- 

Michael "Borlander" Golubev
Eclipse Committer (GMF, UML2Tools)
at Montages Think Tank, Prague, Czech Republic

Montages AG
Stampfenbachstr. 48, CH-8006 Zürich

tel:    +41 44 260 75 57

mob: +420 602 483 463