Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [gef3d-dev] Copyright issues related to CQ2806

Hi everyone,

I have looked through the projects as well and found some minor things only.

Draw3D:


Haven't found anything that differs from your results in Draw3D.

GEF3D:
org.eclipse.gef3d.editpolicies.NonResizableEditPolicy3D
org.eclipse.gef3d.editpolicies.ResizableEditPolicy3D
org.eclipse.gef3d.handles.AbstractHandle3D
org.eclipse.gef3d.handles.HandleBounds3D

HandleBounds3D doesn't look like it was copied from anywhere, it simply extends two interfaces and adds one method. What's up with that?

org.eclipse.gef3d.handles.MoveHandle3D
org.eclipse.gef3d.handles.MoveHandle3DFactory

Same goes for this class. Even if it was copied at one point, the code in there is so simple that I don't think that anyone can have a copyright on it.

org.eclipse.gef3d.handles.MoveHandleLocator3D
org.eclipse.gef3d.handles.NonResizableHandle3DFactory
org.eclipse.gef3d.handles.ResizableHandle3DFactory
org.eclipse.gef3d.handles.ResizeHandle3D

It seems that the classes in this entire package are so simple - I don't see how that stuff can be copyrighted. On the other hand, better safe than sorry I guess.

org.eclipse.gef3d.tools.DragEditPartsTracker3D
org.eclipse.gef3d.tools.ResizeTracker3D
org.eclipse.gef3d.ui.parts.GraphicalEditor3DWithFlyoutPalette
org.eclipse.gef3d.ui.parts.GraphicalEditor3DWithPalette

I have modified the headers of the following files:
org.eclipse.gef3d.preferences.BitFieldEditor (was copied from org.eclipse.jface.preference.RadioGroupFieldEditor)

This may be a problematic case since we don't use the jface plugin from which RadioGroupFieldEditor originates - Sharon Corbett noted that if we didn't reuse the plugin we copied from, we need to open a new CQ.

org .eclipse .gef3d.ui.parts.GraphicalEditor3D#createGraphicalViewer(Composite) - copied from GEF GraphicalViewer class. org .eclipse .gef3d .examples .ecore.diagram.part.EcoreDiagramEditor3D#configureGraphicalViewer() was copied from GEF GraphicalEditor and GMF DiagramEditor.

org .eclipse.gef3d.gmf.runtime.diagram.ui.editparts.DiagramRootEditPart3D - this one is fine, I didn't copy anything for it.

That's all I could find.

Best regards
Kristian


Back to the top