Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [gef-dev] Multi-branch build for GEF Classic

Hi,

On Tue, 2023-12-12 at 20:46 +0100, Patrick Ziegler via gef-dev wrote:
>  
> Hi Alois,
>  
> yeah, that's something I noticed as well. My current plan is to
> configure the Jenkinsfile to only promote when building on the
> "master" branch.
>  
> But this is just a band-aid. In general, we should probably consider
> cleanup up our build process. The only problem being that I don't
> really know what the required steps are...
>  
> @Ed You did something similar for the WindowBuilder project. Do you
> have some advice on how I could get started?

Ed announced in a GEF 5 Issue that he has something prepared:
https://github.com/eclipse/gef/pull/115#issuecomment-1849590292

For which I'm super happy as this is a blind spot on my knowledge map.

>  
>  > PS: I noticed a branch with my name. Should this one be deleted? 
> It's your branch. If you don't need it, just delete it ;D

I didn't even know it was there. So will definitely deleted. I only
have to find out how I created it ;-)

>  
>  
> 
>  
>  
> Many regards,
>  
> Patrick
>  
>  
> On 12.12.23 20:40, Alois Zoitl wrote:
>  
>  
> >  
> > Hi Patrick,
> > 
> > everything that makes our build better is good. The only thing that
> > I'm
> > concerned of is that the old build created promoted to
> > https://download.eclipse.org/tools/gef/classic/latest/
> > 
> > Do we want that for every PR? Or would we do this in a new separate
> > build job that would only run at midnight?
> > 
> > BR,
> > Alois
> > 
> > PS: I noticed a branch with my name. Should this one be deleted?
> > 
> > 
> > On Tue, 2023-12-12 at 20:29 +0100, Patrick Ziegler via gef-dev
> > wrote:
> >  
> > >  
> > > Hello everyone,
> > > 
> > > I've set up a new multi-branch pipeline on the Jenkins to
> > > deprecate
> > > the 
> > > old job.
> > > 
> > > New: https://ci.eclipse.org/gef/job/build-classic/
> > > 
> > > Old: https://ci.eclipse.org/gef/job/gef-classic-latest/
> > > 
> > > 
> > > Main motivation being that the new job has a built-in GitHub 
> > > integration, meaning the build is also triggered for each 
> > > pull-request/branch
> > > 
> > > and (more importantly) is also included in the automatic checks
> > > that 
> > > shown in the browser.
> > > 
> > > I've disabled the old job and -if there are no objections- plan
> > > to 
> > > delete it within the next few days.
> > > 
> > > 
> > > Many regards,
> > > 
> > > Patrick
> > > 
> > > _______________________________________________
> > > gef-dev mailing list
> > > gef-dev@xxxxxxxxxxx
> > > To unsubscribe from this list, visit
> > > https://www.eclipse.org/mailman/listinfo/gef-dev
> > >  
> >   
>  
> _______________________________________________
> gef-dev mailing list
> gef-dev@xxxxxxxxxxx
> To unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/gef-dev



Back to the top