[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [equinox-dev] Equinox Aspects CachingService

Hi Heiko,

2. I wonder if AspectJAdaptor.shouldWeave() ever returns false.
I checked with a modified implementation of AspectJHook (see 1.) where my caching seemed to work but after loading the woven class (from cache) sholdWeave() returned true.
Is this magic method surely working correctly? Could anone please explain that "first four bytes logic" of shouldWeave() to me?

I analyzed this and found a possible explanation as well as a possible fix. The explanation can be found here:


https://bugs.eclipse.org/bugs/show_bug.cgi?id=161202#c3

The fix is in HEAD.

4. The method ICachingService.hashNamespace() is never used externally, thus can be removed from the interface. Right?

Correct. Will fix this.

Best regards,
-Martin