[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
AW: [equinox-dev] Equinox Aspects CachingService

Hi Martin,

Great! I could get my caching service prototype running. Thanks a lot.

Please take a look at https://bugs.eclipse.org/bugs/show_bug.cgi?id=215177. Equinox Aspects 1.0.4 is not compatible with AJDT 1.5.1 / AJ 1.5.4. I already provided a patch.

Please also note, that the Bundle-Versions of org.aspectj.osgi and org.aspectj.osgi.service.weaving are not uptodate.

Regards,
Heiko

-----Ursprüngliche Nachricht-----
Von: equinox-dev-bounces@xxxxxxxxxxx [mailto:equinox-dev-bounces@xxxxxxxxxxx] Im Auftrag von Martin Lippert
Gesendet: Samstag, 12. Januar 2008 20:51
An: Equinox development mailing list
Betreff: Re: [equinox-dev] Equinox Aspects CachingService

Hi Heiko,

> 2. I wonder if AspectJAdaptor.shouldWeave() ever returns false.
> I checked with a modified implementation of AspectJHook (see 1.) where 
> my caching seemed to work but after loading the woven class (from cache) 
> sholdWeave() returned true.
> Is this magic method surely working correctly? Could anone please 
> explain that "first four bytes logic" of shouldWeave() to me?

I analyzed this and found a possible explanation as well as a possible 
fix. The explanation can be found here:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=161202#c3

The fix is in HEAD.

> 4. The method ICachingService.hashNamespace() is never used externally, 
> thus can be removed from the interface. Right?

Correct. Will fix this.

Best regards,
-Martin

_______________________________________________
equinox-dev mailing list
equinox-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/equinox-dev