Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [epp-dev] Default enablement policy for Code Recommenders in EPP packages

The proposal approach is ready. See [1] for screenshot. I’m going to release that change next Tuesday to see how people like it. M4 is in 3 weeks from then. Please comment on the bug [2] if you have concerns with that approach.

Thanks,
Marcel



[1] https://bugs.eclipse.org/bugs/attachment.cgi?id=237605&action=edit
[2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=422177


Am 20.11.2013 um 19:35 schrieb Marcel Bruch <bruch@xxxxxxxxxxxxxxxxxx>:

> I opened Bug 422177 [1] to track progress on this and sketched a possible implementation. I’ll implement it and let you know when it’s ready to get your final feedback.
> 
> Thanks,
> Marcel
> 
> 
> [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=422177
> 
> 
> Am 20.11.2013 um 18:01 schrieb Doug Schaefer <dschaefer@xxxxxxx>:
> 
>> Interesting approach, and yeah, I’m more fine with that :)
>> 
>> From: Marcel Bruch <marcel.bruch@xxxxxxxxxxxxxx>
>> Reply-To: Eclipse Packaging Project <epp-dev@xxxxxxxxxxx>
>> Date: Wednesday, November 20, 2013 at 11:58 AM
>> To: Eclipse Packaging Project <epp-dev@xxxxxxxxxxx>
>> Subject: Re: [epp-dev] Default enablement policy for Code Recommenders in EPP packages
>> 
>> you mean when content assist pops up, the first proposal would be „Wanna enable/configure code recommenders?“ Would be a nice popup-in-a-popup - Doug probably could not complain much about it ;-) I’d be fine with this.
>> 
>> Marcel
>> 
>> Am 20.11.2013 um 17:53 schrieb Igor Fedorenko <igor@xxxxxxxxxxxxxx>:
>> 
>>> Can you offer "Enable Code Recommenders" code assist as default
>>> behaviour? and possibly provide a way to remove this default code assist
>>> to be extra nice to people who don't want code recommenders.
>>> 
>>> --
>>> Regards,
>>> Igor
>>> 
>>> On 11/20/2013, 11:44, Marcel Bruch wrote:
>>>> I’ve mixed feelings on enabling recommenders by default.
>>>> 
>>>> There are many discussions about performance these days and I know that
>>>> Code Recommenders can cause a recognizable delay when loading a model
>>>> the first time ( <100ms but recognizable). With our latest approaches we
>>>> may be able to further reduce this but it will certainly not get much
>>>> faster than 40ms avg. So whenever you trigger code completion the first
>>>> time on, say, java.lang.String, it will take 40ms to load the model into
>>>> the cache. I’ve the feeling that this should be a decision a developer
>>>> explicitly makes.
>>>> 
>>>> Regarding integrating Mylyn:
>>>> Should be simple. We could get together for an afternoon and should be
>>>> done. I’d offer to maintain the small extension.
>>>> 
>>>> Marcel
>>>> 
>>>> Am 20.11.2013 um 16:32 schrieb Steffen Pingel
>>>> <steffen.pingel@xxxxxxxxxxx <mailto:steffen.pingel@xxxxxxxxxxx>>:
>>>> 
>>>>> I had the same thought. If you want users to benefit make it the
>>>>> default. We should chat if it makes sense to add task-focus to the
>>>>> code recommenders content assist. It just another way to proposals so
>>>>> an integration API could be fairly simple and users wouldn't have to
>>>>> make a choice but get the best of both worlds (if that scenario makes
>>>>> sense).
>>>>> 
>>>>> Steffen
>>>>> 
>>>>> 
>>>>> On Wed, Nov 20, 2013 at 4:17 PM, Doug Schaefer <dschaefer@xxxxxxx
>>>>> <mailto:dschaefer@xxxxxxx>> wrote:
>>>>> 
>>>>>   Yeah, no popups. We should be banning pop-ups across the board.
>>>>>   They¹re
>>>>>   super annoying. It would be hard to find a UX expert who would
>>>>>   disagree
>>>>>   except for the most critical of messages (like workspace out of
>>>>>   memory).
>>>>> 
>>>>>   Personally, I¹d like to see a better Welcome page that becomes
>>>>>   part of the
>>>>>   users workflow. It would be a great place to bring things like
>>>>>   that to the
>>>>>   attention of users.
>>>>> 
>>>>>   I guess the other side of that question, why not turn code
>>>>>   recommenders on
>>>>>   all the time?
>>>>> 
>>>>>   Doug.
>>>>> 
>>>>>   On 11/20/2013, 9:56 AM, "Marcel Bruch"
>>>>>   <marcel.bruch@xxxxxxxxxxxxxx <mailto:marcel.bruch@xxxxxxxxxxxxxx>>
>>>>>   wrote:
>>>>> 
>>>>>> Hi package maintainers,
>>>>>> 
>>>>>> by default Code Recommenders content assist silently disables
>>>>>   itself if
>>>>>> it finds the standard Java or Mylyn content assist being enabled
>>>>>   on the
>>>>>> default tab. On the Eclipse booth at Devoxx last week it turned
>>>>>   out that
>>>>>> many Eclipse users did not know about Code Recommenders being already
>>>>>> available in their installations because of this silent deactivation.
>>>>>> 
>>>>>> I¹m now looking for ways how to make Recommenders content assist more
>>>>>> prominent so that Eclipse users get aware of it. Adding it to the
>>>>>   welcome
>>>>>> page may work but many say it¹s not read very often. I wonder how
>>>>>   you¹d
>>>>>> feel about a popup that (when code completion is triggered the first
>>>>>> time) informs a user about the engine being available and asking
>>>>>   a user
>>>>>> to enable it or not.
>>>>>> 
>>>>>> What do you think?
>>>>>> 
>>>>>> Thanks,
>>>>>> Marcel
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> _______________________________________________
>>>>>> epp-dev mailing list
>>>>>> epp-dev@xxxxxxxxxxx <mailto:epp-dev@xxxxxxxxxxx>
>>>>>> https://dev.eclipse.org/mailman/listinfo/epp-dev
>>>>> 
>>>>>   _______________________________________________
>>>>>   epp-dev mailing list
>>>>>   epp-dev@xxxxxxxxxxx <mailto:epp-dev@xxxxxxxxxxx>
>>>>>   https://dev.eclipse.org/mailman/listinfo/epp-dev
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> --
>>>>> Steffen Pingel
>>>>> Principal Software Engineer, Eclipse Mylyn
>>>>> Mylyn Tasks Lead
>>>>> http://tasktop.com <http://tasktop.com/>
>>>>> _______________________________________________
>>>>> epp-dev mailing list
>>>>> epp-dev@xxxxxxxxxxx <mailto:epp-dev@xxxxxxxxxxx>
>>>>> https://dev.eclipse.org/mailman/listinfo/epp-dev
>>>> 
>>>> --
>>>> Eclipse Code Recommenders:
>>>> www.eclipse.org/recommenders <http://www.eclipse.org/recommenders>
>>>> 
>>>> 
>>>> 
>>>> 
>>>> 
>>>> _______________________________________________
>>>> epp-dev mailing list
>>>> epp-dev@xxxxxxxxxxx
>>>> https://dev.eclipse.org/mailman/listinfo/epp-dev
>>>> 
>>> _______________________________________________
>>> epp-dev mailing list
>>> epp-dev@xxxxxxxxxxx
>>> https://dev.eclipse.org/mailman/listinfo/epp-dev
>> 
>> _______________________________________________
>> epp-dev mailing list
>> epp-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/epp-dev
> 
> -- 
> Eclipse Code Recommenders:
> www.eclipse.org/recommenders
> 
> 
> 

-- 
Eclipse Code Recommenders:
www.eclipse.org/recommenders





Back to the top