Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [egit-dev] Let's debate about "Commit and Push" behaviour

Yes, I'm aware of this. I just said, that we do it in our coporate (Gerrit only) environment - not for everybody ;)

Cheers,
Markus

> -----Ursprüngliche Nachricht-----
> Von: Alex Blewitt [mailto:alex.blewitt@xxxxxxxxx]
> Gesendet: Montag, 18. August 2014 13:22
> An: Duft Markus
> Cc: Robin Rosenberg; Mickael Istria; EGit developer discussion
> Betreff: Re: [egit-dev] Let's debate about "Commit and Push" behaviour
>
> There are plenty of cases in pushing to non-Gerrit systems (specifically, GitHub) where removing the 'push to upstream'
> would be a bad idea.
>
> Alex
>
> On 18 Aug 2014, at 12:07, Duft Markus <Markus.Duft@xxxxxxxxxxxxxxxx> wrote:
>
> > Hey,
> >
> > My 2 cent: we roll our own EGit build as we remove those "dangerous" actions from EGit:
> >
> > * Commit & Push in staging view
> > * Pull (We're working with gerrit, and people tend to do it wrong :( )
> > * Push to upstream (most of the time not what people want - we use Push to Gerrit... all the time).
> >
> > Maybe even some more I cannot recall currently ;) If there would be something like a "Save Mode" or "Gerrit Mode"
> (and of course the "Expert mode") for EGit as a whole (menus, staging view, commit dialog, ...) that would be really, really
> great. Of course labeling the button more detailed, or even having that drop down on the button (I like that, but could you
> also add a Push to Gerrit... in there then?) helps already (we'll remove that button still anyhow until it's not a one-click-
> destroy-my-gerrit-button anymore ;)).
> >
> > Cheers,
> > Markus
> >
> >> -----Ursprüngliche Nachricht-----
> >> Von: egit-dev-bounces@xxxxxxxxxxx [mailto:egit-dev-bounces@xxxxxxxxxxx] Im Auftrag von Robin Rosenberg
> >> Gesendet: Montag, 18. August 2014 10:43
> >> An: Mickael Istria
> >> Cc: egit-dev@xxxxxxxxxxx
> >> Betreff: Re: [egit-dev] Let's debate about "Commit and Push" behaviour
> >>
> >>
> >>
> >> ----- Ursprungligt meddelande -----
> >>> Från: "Mickael Istria" <mistria@xxxxxxxxxx>
> >>> Till: egit-dev@xxxxxxxxxxx
> >>> Skickat: måndag, 18 aug 2014 9:40:59
> >>> Ämne: Re: [egit-dev] Let's debate about "Commit and Push" behaviour
> >>>
> >>> Hi all,
> >>>
> >>> I red the various contributions to this discussion, and they all added
> >>> good value to the debate, driving the initial issue to a bunch of
> >>> possible action items.
> >>> I agree the most with Robin's comment: the issue I have is not that much
> >>> that I can't use "Commit and Push" but more that I don't know what it is
> >>> going to do. So just showing the label of the default destination would
> >>> be a very great first iteration IMO. "Commit and Push to origin:master"
> >>> or "Commit and Push to gerrit:refs/for/master" as label of the button
> >>
> >> +1 for that. The user should not be in doubt about what is going to happen.
> >>
> >>> would be quite helpful. [1] I also believe for example that "Push to
> >>> upstream" could be changed in a similar way to directly show the
> >>> destination, so user doesn't need to remember what's upstream for each
> >>> branch. [2].
> >>
> >> And +1, might keep the term upstream together with the translation of what
> >> that means.
> >>
> >> Add whether pull means merge or rebase to that, though that's not nearly
> >> as dangerous when the action taken is not excpected.
> >>
> >> -- robin
> >>
> >>> I agree a drop-down button would be nice [3], but I have the impression
> >>> it's not as important as disambiguating the "Commit and Push" label.
> >>>
> >>> Cheers,
> >>>
> >>> [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=441938
> >>> [2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=441940
> >>> [3] https://bugs.eclipse.org/bugs/show_bug.cgi?id=441941
> >>>
> >>> _______________________________________________
> >>> egit-dev mailing list
> >>> egit-dev@xxxxxxxxxxx
> >>> To change your delivery options, retrieve your password, or unsubscribe from
> >>> this list, visit
> >>> https://dev.eclipse.org/mailman/listinfo/egit-dev
> >>>
> >> _______________________________________________
> >> egit-dev mailing list
> >> egit-dev@xxxxxxxxxxx
> >> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> >> https://dev.eclipse.org/mailman/listinfo/egit-dev
> > Salomon Automation GmbH | Friesachstrasse 15 | 8114 Friesach bei Graz | Austria
> > Registered Office: Friesach bei Graz | Commercial Register: 49324 K | VAT no. ATU28654300
> > Commercial Court: Landesgericht für Zivilrechtssachen Graz
> > _______________________________________________
> > egit-dev mailing list
> > egit-dev@xxxxxxxxxxx
> > To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> > https://dev.eclipse.org/mailman/listinfo/egit-dev

Salomon Automation GmbH | Friesachstrasse 15 | 8114 Friesach bei Graz | Austria
Registered Office: Friesach bei Graz | Commercial Register: 49324 K | VAT no. ATU28654300
Commercial Court: Landesgericht für Zivilrechtssachen Graz


Back to the top