Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [egit-dev] Are additional Gerrit IP Review status possible?

Gunnar Wagenknecht <gunnar@xxxxxxxxxxxxxxx> wrote:
> Am 21.05.2010 09:14, schrieb Gunnar Wagenknecht:
> > * no CQ necessary, CQ approved, CQ rejected :)
> 
> * no CQ necessary,CQ submitted, CQ approved, CQ rejected

The scores don't work quite like that.  The values for a category
need to be in a numerical range.  The highest score must be given
to allow the change to be submitted.

How do we rank it?

  +1  CQ approved or not necessary
  -1  CQ submitted
  -2  CQ rejected

?

BTW, that's sort of the point of the IP Clean flag we have now.

-- 
Shawn.


Back to the top