Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [egit-dev] UI tests: current SWTBot requires JUnit 4

Sorry, I did not have time to work on release tycho 0.7.0 last week.
Will try to do this later today.

As for running SWTBot tests, you'll basically need to add
<useUIThread>false</useUIThread> to test mojo configuration in your pom.xml.

--
Regards,
Igor

Matthias Sohn wrote:
2010/1/26 Igor Fedorenko <ifedorenko@xxxxxxxxxxxx <mailto:ifedorenko@xxxxxxxxxxxx>>

    Matthias Sohn wrote:

        For the UI tests based on SWTBot posted by Robin [1] and
        improved by Ketan [2] we need to use JUnit 4 [3].
        I am wondering if we should also update the other JUnit tests
        from JUnit 3.8 or are there any arguments against this ?

        I tested combination of [1] and [2] successfully and would now
        like to bring this series forward.

        If there are no objections I would rebase [1] and [2] to get rid
        of the unnecessary merge reformat the commit message
        of [2] to follow our style and file CQs for Ketan's change (454
        lines) and the SWTBot dependencies specified in [4] :

        org.eclipse.swtbot.eclipse.finder;bundle-version="2.0.0"
        org.eclipse.swtbot.eclipse.spy;bundle-version="2.0.0"
        org.eclipse.swtbot.eclipse.ui;bundle-version="2.0.0"
        org.eclipse.swtbot.swt.finder;bundle-version="2.0.0"
        org.eclipse.swtbot.junit4_x;bundle-version="2.0.0"

        org.apache.log4j;bundle-version="1.2.13"
        org.hamcrest;bundle-version="1.1.0"
        org.junit;bundle-version="4.3.1"

        and then start working on
        - getting rid of the dependency to the external git site [5]
        - integration into the Maven build

        Comments, thoughts ?

        [1] http://egit.eclipse.org/r/#change,137
        [2] http://egit.eclipse.org/r/#change,208
        [3] http://wiki.eclipse.org/SWTBot/UsersGuide#Configuration
        [4]
        http://egit.eclipse.org/r/#patch,unified,208,1,org.eclipse.egit.ui.test/META-INF/MANIFEST.MF
        [5] http://dev.eclipse.org/mhonarc/lists/egit-dev/msg00701.html


    On Tue, Jan 26, 2010 at 10:29 AM, Igor Fedorenko
    <ifedorenko@xxxxxxxxxxxx <mailto:ifedorenko@xxxxxxxxxxxx>> wrote:
    FYI, you need tycho 0.7.0-SNAPSHOT and specify <useUIThread>false</

        useUIThread> new osgi-test mojo parameter to run SWTBot tests
        from maven.

    As Jason pointed out, you need to wait until we release tycho 0.7.0.
    Using thirdparty snapshot builds is a really bad idea. I'll try to
    push Tycho release later this week. Sorry for the confusion.


Any news on Tycho 0.7.0 ? Robin's and Ketan's change passed IP and code review so I could start working on
mavenizing these SWTBot tests. Any hints how to integrate them using Tycho ?
--
Matthias


Back to the top