| [egit-dev] Is org.eclipse.egit.core--All-Tests broken in 'master'? |
Hi there,
As I can see org.eclipse.egit.core--All-Tests is broken in
'master' for some time. Here are steps to reproduce:
Checkout the current master branch:
--8<---------------cut here---------------start------------->8---
commit e2eced2b9eb87c26107f6a629572ebe7eda11b78
Author: Remy Suen <remysuen@xxxxxxxxxx>
Date: Fri Oct 16 18:52:35 2009 -0400
Fix conflicting button mnemonic in clone wizard
--8<---------------cut here---------------end--------------->8---
Open org.eclipse.egit.core.test/org.eclipse.egit.core--All-Tests.launch
and check that workspace data location points to a directory not nested
into an existed git repository. As my workspace is under git control I
forced to point tests to somewhere like '/tmp/junit-workspace':
--8<---------------cut here---------------start------------->8---
diff --git a/org.eclipse.egit.core.test/org.eclipse.egit.core--All-Tests.launch b/org.eclipse.egit.core.test/org.eclipse.egit.core--All-Tests.launch
index 10b0eb7..e246fe7 100644
--- a/org.eclipse.egit.core.test/org.eclipse.egit.core--All-Tests.launch
+++ b/org.eclipse.egit.core.test/org.eclipse.egit.core--All-Tests.launch
@@ -11,7 +11,7 @@
<stringAttribute key="configLocation" value="${workspace_loc}/.metadata/.plugins/org.eclipse.pde.core/pde-junit"/>
<booleanAttribute key="default" value="true"/>
<booleanAttribute key="includeOptional" value="true"/>
-<stringAttribute key="location" value="${workspace_loc}/../junit-workspace"/>
+<stringAttribute key="location" value="/tmp/junit-workspace"/>
<listAttribute key="org.eclipse.debug.core.MAPPED_RESOURCE_PATHS">
<listEntry value="/org.eclipse.egit.core.test"/>
</listAttribute>
--8<---------------cut here---------------end--------------->8---
Ok, run tests and if I'm not mistaken you'll get exactly this:
--8<---------------cut here---------------start------------->8---
org.eclipse.egit.core--All-Tests
org.eclipse.egit.core.op.T0001_ConnectProviderOperationTest
testNoRepository(org.eclipse.egit.core.op.T0001_ConnectProviderOperationTest)
junit.framework.AssertionFailedError
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertTrue(Assert.java:27)
at org.eclipse.egit.core.op.T0001_ConnectProviderOperationTest.testNoRepository(T0001_ConnectProviderOperationTest.java:44)
[...]
--8<---------------cut here---------------end--------------->8---
It's time to check the same for a project nested into a git
repository. I use a default path '${workspace_loc}/../junit-workspace'
for that matter because it points to
'/home/mn/workspace-1/../junit-workspace' nested into a git repository
'/home/mn/.git'. Now you'll get a bunch of failures:
--8<---------------cut here---------------start------------->8---
org.eclipse.egit.core--All-Tests
org.eclipse.egit.core.T0003_AdaptableFileTreeIteratorTest
testFileTreeToContainerAdaptation(org.eclipse.egit.core.T0003_AdaptableFileTreeIteratorTest)
java.lang.NullPointerException
at org.eclipse.egit.core.T0003_AdaptableFileTreeIteratorTest.testFileTreeToContainerAdaptation(T0003_AdaptableFileTreeIteratorTest.java:66)
[...]
org.eclipse.egit.core.op.T0001_ConnectProviderOperationTest
testNewRepository(org.eclipse.egit.core.op.T0001_ConnectProviderOperationTest)
junit.framework.AssertionFailedError
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertTrue(Assert.java:27)
at org.eclipse.egit.core.op.T0001_ConnectProviderOperationTest.testNewRepository(T0001_ConnectProviderOperationTest.java:59)
[...]
testNewUnsharedFile(org.eclipse.egit.core.op.T0001_ConnectProviderOperationTest)
junit.framework.AssertionFailedError
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNotNull(Assert.java:217)
at junit.framework.Assert.assertNotNull(Assert.java:210)
at org.eclipse.egit.core.op.T0001_ConnectProviderOperationTest.testNewUnsharedFile(T0001_ConnectProviderOperationTest.java:121)
[...]
org.eclipse.egit.core.internal.mapping.T0002_history
testSingleRevision_1(org.eclipse.egit.core.internal.mapping.T0002_history)
junit.framework.AssertionFailedError
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNotNull(Assert.java:217)
at junit.framework.Assert.assertNotNull(Assert.java:210)
at org.eclipse.egit.core.internal.mapping.T0002_history.testSingleRevision_1(T0002_history.java:123)
[...]
testSingleRevision_2(org.eclipse.egit.core.internal.mapping.T0002_history)
junit.framework.AssertionFailedError
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNotNull(Assert.java:217)
at junit.framework.Assert.assertNotNull(Assert.java:210)
at org.eclipse.egit.core.internal.mapping.T0002_history.testSingleRevision_2(T0002_history.java:134)
testSingleRevision_3(org.eclipse.egit.core.internal.mapping.T0002_history)
junit.framework.AssertionFailedError
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNotNull(Assert.java:217)
at junit.framework.Assert.assertNotNull(Assert.java:210)
at org.eclipse.egit.core.internal.mapping.T0002_history.testSingleRevision_3(T0002_history.java:143)
[...]
testShallowHistory(org.eclipse.egit.core.internal.mapping.T0002_history)
junit.framework.AssertionFailedError
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNotNull(Assert.java:217)
at junit.framework.Assert.assertNotNull(Assert.java:210)
at org.eclipse.egit.core.internal.mapping.T0002_history.testShallowHistory(T0002_history.java:154)
[...]
testDeepHistory_A(org.eclipse.egit.core.internal.mapping.T0002_history)
junit.framework.AssertionFailedError
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNotNull(Assert.java:217)
at junit.framework.Assert.assertNotNull(Assert.java:210)
at org.eclipse.egit.core.internal.mapping.T0002_history.testDeepHistory_A(T0002_history.java:166)
[...]
testDeepHistory_B(org.eclipse.egit.core.internal.mapping.T0002_history)
junit.framework.AssertionFailedError
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNotNull(Assert.java:217)
at junit.framework.Assert.assertNotNull(Assert.java:210)
at org.eclipse.egit.core.internal.mapping.T0002_history.testDeepHistory_B(T0002_history.java:178)
[...]
--8<---------------cut here---------------end--------------->8---
Is it only me who had caught these problems?
--
MAN-UANIC