Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [egit-dev] jgit changes pending review

Alex Blewitt <alex.blewitt@xxxxxxxxx> wrote:
> On Mon, Oct 5, 2009 at 9:06 PM, Shawn O. Pearce <spearce@xxxxxxxxxxx> wrote:
> > I have 5 commits for JGit that I'd like to get an ACK on from
> > someone else before I submit them:
> >
> > Ic243544a ??Standardize the source code formatter for Eclipse
> > I282ee1c6 ??Remove useless test005_todopack test
> > I5700ca48 ??Move setupReflog test function to only test that cares
> > Ia2cce34d ??Move AmazonS3 command line utility to jgit-pgm
> > I2fd81be2 ??Move HttpSupport's configureHttpProxy to jgit-pgm
> 
> These look good to me. Unfortunately, I can't click on approve on the
> Gerrit web interface to record it.

I think the approve button you are trying to find, but can't,
is Publish Comments > Code Review +1 > Publish Comments.

-- 
Shawn.


Back to the top