| Re: [eclipselink-users] EclipseLink 2.0.0 RC 1 code clean up |
Please log a bug for this and include the FindBugs tools output. jandam wrote: > > Today I evaluated EclipseLink 2.0.0 RC 1. It works without problems so > far. > > When I use thirdparty library I check it with FindBugs. FindBugs 1.3.9 > show 1458 bugs in eclipselink.jar and > javax.persistence_2.0.0v200911271158.jar. > Most of them are not bugs. > Some are trivial like replacing & with && in if statement. And some can > be quite dangerous like infinite recursive loop in > "...jpa.querydef.ExpressionImpl.getValue()" > > It found "showstoper" bug in > "...sequencing.PreallocationHandler.getPreallocated(String)" that is > synchronized on ConcurrentLinkedQueue that is prohibited according to > JavaDoc and can lead to deadlock. I experienced such deadlocks in my own > programs when I switched from ArrayList to concurrent implementation. > > Can you consider checking EclipseLink 2.0.0 before final release and > fixing at least some trivial bugs and others delay to 2.0.1 release. > > Martin > > ----- http://wiki.eclipse.org/User:James.sutherland.oracle.com James Sutherland http://www.eclipse.org/eclipselink/ EclipseLink , http://www.oracle.com/technology/products/ias/toplink/ TopLink Wiki: http://wiki.eclipse.org/EclipseLink EclipseLink , http://wiki.oracle.com/page/TopLink TopLink Forums: http://forums.oracle.com/forums/forum.jspa?forumID=48 TopLink , http://www.nabble.com/EclipseLink-f26430.html EclipseLink Book: http://en.wikibooks.org/wiki/Java_Persistence Java Persistence -- View this message in context: http://old.nabble.com/EclipseLink-2.0.0-RC-1-code-clean-up-tp26573939p26581398.html Sent from the EclipseLink - Users mailing list archive at Nabble.com.