RE: [eclipselink-users] Using Tomcat - reply

[cowwoc <cowwoc@xxxxxxxxxxxxxxxx>]

mobrien wrote:
> 
> Gili,
> 	Thank you for your review comments, I am glad to see you using our
> examples.
> 	Please keep in mind that these Tutorials have been tested and verified
> but they are evolving works in progress.
> 
> 	Here are some suggestions for your suggestions.
> 
> 	1) The example already illustrates use of the
> eclipselink.session.customer property set to
> JPAEclipseLinkSessionCustomizer to avoid the javax.naming exception when
> STRING_LOOKUP is not set on the JNDI connector
> 	2) This example is currently using JTA - a common configuration
> originating from a support email that started this tutorial version, the
> non-jta-data-source element is commented out in the example.
> 	3) The final String constant was used as part of a lookup that is not in
> the wiki, I will be adding the code to SVN shortly in
> http://bugs.eclipse.org/250476 and will synchronize wiki with SVN when it
> is queued - the constant should be removed.
> 

All I was trying to say is that someone trying to modify the jta example to
non-jta will run into problems because the String constant in
JPAEclipseLinkSessionCustomizer will mislead them into trying the wrong JNDI
value. Once you remove that constant it should get much better.

Thanks,
Gili
-- 
View this message in context: http://www.nabble.com/Using-Tomcat-tp20367474p20368862.html
Sent from the EclipseLink - Users mailing list archive at Nabble.com.