Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipse.org-committers] Experience using GitHub verus Eclipse.org Hosted Git

>> This has changed: you can now post reactions to issues and
>> pull-requests, see
>> https://github.com/blog/2119-add-reactions-to-pull-requests-issues-and-comments
> Does the PR page reports the summary of +1/-1? Also, would this count be
> updated when a new commit is pushed or one is amended?
> Compared to Gerrit, GitHub seems to be missing some semantics about how
> a code review actually works.

Yes you get a reactions count for the PR (note that pushing new commits
does not have an effect on this).

As usual in Github-land the tools take the route of minimalism, and it
is up to users to build loose conventions on top of that.

I can understand that some teams want more process enforcements in issue
trackers and code review tools, but that's not what everyone wants either.

- Julien


Back to the top