Re: [eclipse-pmc] PMC approval needed for change #119445

["Daniel Megert" <daniel_megert@xxxxxxxxxx>]

I have some concerns
here.

1. org.eclipse.ui.views.framelist#FrameList.reset()
does not seem to be called.
2. Loading the
change gives API Tools errors
3. There are no
test cases or steps that would show the error in the Eclipse SDK (i.e.
without installing Mylyn).

So, for me looks
more like 4.9.

Dani



From:
       Karsten
Thoms <karsten.thoms@xxxxxxxxx>
To:
       eclipse-pmc@xxxxxxxxxxx
Date:
       29.03.2018
15:25
Subject:
       Re:
[eclipse-pmc] PMC approval needed for change #119445
Sent
by:        eclipse-pmc-bounces@xxxxxxxxxxx

---

It is low risk, but also not important.
Of course the contributor would like to see it fixed.
The original patch was only for one of
both TreeViewerFrameSource without API change. But I asked the contributor
to apply it for the copy also. We could also ask to split the patch and
apply the 2nd for 4.9.
WDYT?

~Karsten

Am 29.03.2018 um 12:59 schrieb Lars Vogel <lars.vogel@xxxxxxxxxxx>:

Karsten, how risky and how important
is the patch in your opinion?

Karsten Thoms <karsten.thoms@xxxxxxxxx>
schrieb am Do., 29. März 2018, 12:27:
Dear PMC,

I kindly ask for approval of patch https://git.eclipse.org/r/#/c/119445/

It adds some API methods to apply the patch for both implementations of
TreeViewerFrameSource.

~Karsten

~Karsten

_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-pmc

_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_eclipse-2Dpmc&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=vdh-umxBmbL_NQK_l31sbOVOqTpukYHfvJwoRXC_bS8&s=vMDmDVmTH1PPJjSNoBh_2B2xyhqAYeyNJ4a9H-J4Mow&e=