Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipse-pmc] PMC approval needed for change #119445

The API freeze period is AFAIK designed to prevent risky changes and
to protect downstream projects.

In this case, I don't  think extenders are affected.  Based on
Karstens judgment I vote +1 for this low risk fix.

Lets see, what other PMC members say.


On Thu, Mar 29, 2018 at 3:25 PM, Karsten Thoms <karsten.thoms@xxxxxxxxx> wrote:
> It is low risk, but also not important. Of course the contributor would like
> to see it fixed.
> The original patch was only for one of both TreeViewerFrameSource without
> API change. But I asked the contributor to apply it for the copy also. We
> could also ask to split the patch and apply the 2nd for 4.9.
> WDYT?
>
> ~Karsten
>
> Am 29.03.2018 um 12:59 schrieb Lars Vogel <lars.vogel@xxxxxxxxxxx>:
>
> Karsten, how risky and how important is the patch in your opinion?
>
> Karsten Thoms <karsten.thoms@xxxxxxxxx> schrieb am Do., 29. März 2018,
> 12:27:
>>
>> Dear PMC,
>>
>> I kindly ask for approval of patch https://git.eclipse.org/r/#/c/119445/
>>
>> It adds some API methods to apply the patch for both implementations of
>> TreeViewerFrameSource.
>>
>> ~Karsten
>>
>> ~Karsten
>> _______________________________________________
>> eclipse-pmc mailing list
>> eclipse-pmc@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe
>> from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
>
> _______________________________________________
> eclipse-pmc mailing list
> eclipse-pmc@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
>
>
> _______________________________________________
> eclipse-pmc mailing list
> eclipse-pmc@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/eclipse-pmc



-- 
Eclipse Platform project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com


Back to the top