[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [eclipse-pmc] PMC approval needed for patch https://git.eclipse.org/r/#/c/50300/ ?
|
Andrey, in the old days I would have agreed to you but "IMHO this is
too big/too risky for M7" is IMHO not valid anymore.
M7 is not maximum time we now have for any change. After Photon we
will be releasing every 3 months, so if we do such a change after
Photon we always will have less time compared to M7.
On Tue, Mar 20, 2018 at 9:27 AM, Andrey Loskutov <loskutov@xxxxxx> wrote:
> I'm not a PMC team member, but looking on the change I fully agree with Tom. IMHO this is too big/too risky for M7, such kind of changes should be done much earlier to be able to catch and fix all possible side effects of API generification.
>
> Kind regards,
> Andrey Loskutov
>
> http://google.com/+AndreyLoskutov
>
>
>> Gesendet: Dienstag, 20. März 2018 um 09:18 Uhr
>> Von: "Tom Schindl" <tom.schindl@xxxxxxxxxxxxxxx>
>> An: eclipse-pmc@xxxxxxxxxxx
>> Betreff: Re: [eclipse-pmc] PMC approval needed for patch https://git.eclipse.org/r/#/c/50300/ ?
>>
>> On 19.03.18 22:35, Lars Vogel wrote:
>> > +1 from my side (as I suggest to Conrad to ask the PMC for
>> > permission). I know Conrad and he has a very deep understanding of DB
>> > and I trust his judgment.
>> >
>> > Also, the API relevant change is minimal with only two (small) classes.
>>
>> Really? I count a whole lot of API changes because generics have been
>> added. When you generify an API you have ONLY one chance to get it
>> right, so this needs to be reviewed with special care.
>>
>> Having said that, I have no time to review this stuff.
>>
>> Tom
>> _______________________________________________
>> eclipse-pmc mailing list
>> eclipse-pmc@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
>>
> _______________________________________________
> eclipse-pmc mailing list
> eclipse-pmc@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
--
Eclipse Platform project co-lead
CEO vogella GmbH
Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com
