Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipse-pmc] PMC approval needed for patch https://git.eclipse.org/r/#/c/50300/ ?

On 19.03.18 22:35, Lars Vogel wrote:
> +1 from my side (as I suggest to Conrad to ask the PMC for
> permission). I know Conrad and he has a very deep understanding of DB
> and I trust his judgment.
> 
> Also, the API relevant change is minimal with only two (small) classes.

Really? I count a whole lot of API changes because generics have been
added. When you generify an API you have ONLY one chance to get it
right, so this needs to be reviewed with special care.

Having said that, I have no time to review this stuff.

Tom


Back to the top