Re: [e4-dev] Mandatory Gerrit usage for the e4 project?

[Wim Jongman <wim.jongman@xxxxxxxxx>]

> you have to wait for somebody to review your changes.
A committer does not have to wait for others to review their code. You can review your own code.

> +1 to make it a judgment call for the individual committer (people over

process)

The people over process argument is often used to prevent changes (i'm not saying that you use it in this context btw ;)

> It's just crazy to be forced to go via Gerrit if one wants to e.g. quickly fix a typo or a simple warning in the code

These kind of changes are often needed because people do not take the time to review their commits. Gerrit will help us with this.

Cheers,

Wim

Meskimen's law

"there is never time to do it right but there is always time to do it over" 

On Fri, Nov 22, 2013 at 9:45 AM, Jonas Helming <jonas.helming@xxxxxxxxxxxxxx> wrote:

+1 to leave it up to the committer...

Am 22.11.2013 09:39, schrieb Daniel Megert:

+1 to leave it up to the committer. It's just crazy to be forced to go via Gerrit if one wants to e.g. quickly fix a typo or a simple warning in the code.

Dani


From:        Markus Alexander Kuppe <e4-dev_eclipse.org@xxxxxxxxxxx>
To:        E4 Project developer mailing list <e4-dev@xxxxxxxxxxx>
Date:        22.11.2013 09:35
Subject:        Re: [e4-dev] Mandatory Gerrit usage for the e4 project?
Sent by:        e4-dev-bounces@xxxxxxxxxxx

---

On 11/22/2013 09:28 AM, Daniel Rolka wrote:
> Sometimes Gerrit unnecessary slows down the development - you have to
> wait for somebody to review your changes. It is especially painful when
> you handle several things simultaneously. So I'm not sure if we should
> make it the mandatory step after becoming the committer. Every committer
> can take the code and adjust it when they think sth can be
> refactored/implement in better way. Hovever I think, introducing some
> changes that can break sth/block sb or you are not sure if it is correct
> we should commit changes via Gerrit to get feedback,
>
> +1 for preparing the Hudson build for E4

+1 to make it a judgment call for the individual committer (people over
process).

M.
_______________________________________________
e4-dev mailing list
e4-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/e4-dev

_______________________________________________
e4-dev mailing list
e4-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/e4-dev

_______________________________________________
e4-dev mailing list
e4-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/e4-dev