[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
Re: [e4-dev] Mandatory Gerrit usage for the e4 project?
|
+1
Met vriendelijke groet,
Wim
> On 21 nov. 2013, at 18:56, Lars Vogel <lars.vogel@xxxxxxxxx> wrote:
>
> Hi,
>
> I grew very found of using Gerrit instead of direct pushes to the Git repo. I see the following advantages:
>
> 1.) I can validate myself, if I pushed the right thing. I frequently see in Gerrit that I pushed unintentially whitespace and I can correct that before I commit
> 2.) I document what I did for others
> 3.) Others have the possibility to see what I did and can comment or learn from it
> 4.) It is IMHO fair to Eclipse contributors as I use the same workflow as contributors
>
> What is the general opinion about Gerrit? If the majority of e4 committers is in favor of using it, I would like to suggest that direct pushes are disabled so that every contribution would go via Gerrit.
>
> We could (in the future) also setup Gerrit build triggers to validate that change don't break the build.
>
> Best regards, Lars
> _______________________________________________
> e4-dev mailing list
> e4-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/e4-dev