Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [e4-dev] Themes for Eclipse 4

Hi Tom,

is replacing the icons already supported by the CSS engine or shall I
open a bug report for that?

Best regards, Lars

2012/7/13 Tom Schindl <tom.schindl@xxxxxxxxxxxxxxx>:
> Well potentially icons even have to change based on the theme, so
> there's bit of a mismatch between theme and application model in this
> regard.
>
> So i think the icons defined in the model can only act as defaults and
> can be overwritten by CSS-Definitions:
>
> #save {
>   image: url();
> }
>
> #save:disabled {
>   image: url();
> }
>
> #save:hover {
>   image: url();
> }
>
> Tom
>
> Am 13.07.12 08:03, schrieb Toedter, Kai:
>>> 2012/7/12 Gerald Rosenberg <gerald@xxxxxxxxxx>:
>>>> The backgrounds of these icons are transparent.  The white/lite
>>>> colored pixels are non-transparent artifacts.  All that is needed is a
>>>> bit of pixel editing to remove them.
>> The only way to have a consistent icon set that looks good on dark and light backgrounds is to provide icons with a real alpha channel. 100% transparency per background pixel, like we have it now, does not work in terms of a professional look. PNG supports this pretty good. But this would lead to a redesign of ALL icons used in Eclipse.
>>
>> Best regards,
>>
>> Kai
>>
>>> -----Original Message-----
>>> From: e4-dev-bounces@xxxxxxxxxxx [mailto:e4-dev-bounces@xxxxxxxxxxx]
>>> On Behalf Of Lars Vogel
>>> Sent: Freitag, 13. Juli 2012 07:15
>>> To: E4 Project developer mailing list
>>> Subject: Re: [e4-dev] Themes for Eclipse 4
>>>
>>> Hi,
>>>
>>> sounds easy enough.
>>>
>>> @Sopot can you please open a bug for that?
>>>
>>> Best regards, Lars
>>>
>>> 2012/7/12 Gerald Rosenberg <gerald@xxxxxxxxxx>:
>>>> The backgrounds of these icons are transparent.  The white/lite
>>>> colored pixels are non-transparent artifacts.  All that is needed is a
>>>> bit of pixel editing to remove them.
>>>>
>>>> Best,
>>>> Gerald
>>>>
>>>> In article <CAOeJ3wvxszE+KWVVAeAtNOqCU5KYXTYzzwD0tz1=tESNvpu-
>>>> 8Q@xxxxxxxxxxxxxx>, lars.vogel@xxxxxxxxx says...
>>>> |
>>>> |Hi Sopot,
>>>> |
>>>> |but if all icons would have transparent background, this would work, right?
>>>> |
>>>> |Best regards, Lars
>>>> |
>>>> |2012/7/12 Sopot Çela <sopotcela@xxxxxxxxx>:
>>>> |> Hi Lars,
>>>> |>
>>>> |> I'm not sure of the technical effort to achieve this but I thought
>>>> |> It should be brought up also as it risked to be frogotten through
>>>> |> the CSS issues. IMHO any dark theme needs other icons as the white
>>>> |> pixels in the edges (on black
>>>> |> background) really interfere with the slick look of the rest of the theme.
>>>> |>
>>>> |> Sopot
>>>> |>
>>>> |> On Jul 12, 2012, at 20:41, Lars Vogel <lars.vogel@xxxxxxxxx> wrote:
>>>> |>
>>>> |> Hi Sopot,
>>>> |>
>>>> |> is it "just" an issue of replacing the icons or is it also a
>>>> |> technical issue?
>>>> |>
>>>> |> Best regards, Lars
>>>> |>
>>>> |> 2012/7/12 Sopot Çela <sopotcela@xxxxxxxxx>
>>>> |>>
>>>> |>>  I just tried the theme and think that Roger's concern regarding
>>>> |>> (quote)
>>>> |>>
>>>> |>> - Is there a way to get PNG icons with alpha transparency instead
>>>> |>> of those with the white pixels around them?
>>>> |>>
>>>> |>> should also be tracked as they show various glitches in dark
>>>> |>> themes. I guess the closing icon X in parts also suffers from the same
>>> problem.
>>>> |>>
>>>> |>> Maybe Roger can confirm that better than me.
>>>> |>>
>>>> |>> Sopot
>>>> |>>
>>>> |>>
>>>> |>> On Thu, Jul 12, 2012 at 11:20 AM, Lars Vogel <lars.vogel@xxxxxxxxx>
>>> wrote:
>>>> |>>>
>>>> |>>> Hello Mike,
>>>> |>>>
>>>> |>>> as suggested by you I opened a separate bugs for the styling of
>>>> |>>> the table
>>>> |>>> header: https://bugs.eclipse.org/bugs/show_bug.cgi?id=384906
>>>> |>>>
>>>> |>>> I keep track of all related CSS styling bugs, I suggest to have a
>>>> |>>> master bug which keeps a reference to all related bugs. I opened for
>>> this purpose:
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> e4-dev mailing list
>>>> e4-dev@xxxxxxxxxxx
>>>> https://dev.eclipse.org/mailman/listinfo/e4-dev
>>> _______________________________________________
>>> e4-dev mailing list
>>> e4-dev@xxxxxxxxxxx
>>> https://dev.eclipse.org/mailman/listinfo/e4-dev
>> _______________________________________________
>> e4-dev mailing list
>> e4-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/e4-dev
>>
>
>
> --
> B e s t S o l u t i o n . a t                        EDV Systemhaus GmbH
> ------------------------------------------------------------------------
> tom schindl                 geschäftsführer/CEO
> ------------------------------------------------------------------------
> eduard-bodem-gasse 5-7/1   A-6020 innsbruck     fax      ++43 512 935833
> http://www.BestSolution.at                      phone    ++43 512 935834
>
>
> _______________________________________________
> e4-dev mailing list
> e4-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/e4-dev


Back to the top