[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
Am 16.08.11 03:50, schrieb Bogdan Gheorghe:
> Hi Tom -
>
> Your observations are right on - there needs to be a better distinction
> made between our "custom" CSS syntax and the standard selectors. I'm all
> for refactoring the custom property names - I've opened
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=354783to track this.
>
Ok. Just to be clear:
* selector is (id,class,pseudo) selector
* property is (color,background,...)
You seem to mix those 2 here and in the bug report. We don't have custom
selectors but custom properties.
> We also really need a CSS editor both for code completion and for "live"
> editing of a CSS file. I'm not sure if you had a bug open for this -
> I've created https://bugs.eclipse.org/bugs/show_bug.cgi?id=354785just in
> case. I'm not sure how far along you are, but I'd be ready and willing
Great - I'm going to add my current sources there but we might also talk
to Nitin because from his reply to the topic it sounded like I've also
been working on this.
> to help. Having a dependency on XText for the tooling is OK but I don't
> know if we would want to add it as a dependency to the css core
> (something to look at later).
>
Well IIRC you don't have a whole lot of dependencies for parsing files
because Xtext generates Java code to parse files and creating an in
memory EMF model of the css file but using Xtext at runtime is a minor
topic to me (though not unimportant) first and most important is tooling
and the usage of valid css-constructs.
Tom
> Bogdan
>
> PS. Some of those constructs that you mentioned were giving the editor a
> hard time should be alright. I've seen legit examples of combing a class
> id with an id selector:
>
> <h1 id="one" class="two">This Should Be
> Red</h1><https://bugs.eclipse.org/bugs/show_bug.cgi?id=354785>
>
> #one.two { color: red; }
>
id + class selector are not really hard but the problem because they are
valid. The problem are the invalid selectors:
.MTrimmedWindow.topLevel = class + class selector
.MTrimBar#org-eclipse-ui-main-toolbar = class + id selector
Tom
