[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
[dsdp-tm-dev] FW: RSE Build N20070215-0100 failed
|
Hi all,
we have another winner of the "I broke the build" award:
Michael Scharf slipped into two nasty traps yesterday.
First Problem:
--------------
When moving packages in org.eclipse.tm.terminal.view,
in order to comply with Eclipse Naming Conventions
for "internal", Michael committed the moved packages
from the new location but forgot to also commit the
removal of the old packages (so they were duplicate
in the repository).
This is a nasty problem: it looks like the CVS ">"
label decorators are not consistently there when
stuff is only removed. I could not reproduce this
issue consistently though, so I did not file a bug
for this.
Second Problem:
---------------
Michael also modified the .classpath file of
org.eclipse.tm.terminal.serial, thereby removing
access control patterns that are required in order
to successfully find rxtx in the JVM ext location.
I suppose that this happened automatically, when
doing "PDE Tools > Update Classpath" so again it was
a nasty trap. For this, there is existing bug
https://bugs.eclipse.org/bugs/show_bug.cgi?id=154593
What we can learn from this:
----------------------------
1. When moving packages, don't rely on the Eclipse ">"
marker for things to be committed but better commit
all the projects that could have been possibly modified.
2. Don't mess around with .project, .settings, .classpath
unless you fully understand what the settings are good
for.
3. When moving stuff around, please remember the convention
for the commit comment, so the old package name is known
in order to allow "restore from repository" later:
[refactor] move org.eclipse.tm.terminal.internal.view ->
org.eclipse.tm.internal.terminal.view
in case the refactoring modifies API, it is good to have
a bugzilla bug associated for documenting the API change:
[174163][api] make org.eclipse.tm.terminal.control internal
I fixed the issues and restarted the N-build.
Isn't it good we have it?
Cheers,
--
Martin Oberhuber
Wind River Systems, Inc.
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm
-----Original Message-----
From: martin.oberhuber@xxxxxxxxxxxxx
[mailto:martin.oberhuber@xxxxxxxxxxxxx]
Sent: Thursday, February 15, 2007 7:09 AM
To: Oberhuber, Martin
Subject: RSE Build N20070215-0100 failed
# 2/15/07 1:04:07 AM EST
# Eclipse Java Compiler 0.727, 3.3.0 milestone-4, Copyright IBM Corp
2000, 2006. All rights reserved.
----------
3. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 42)
import org.eclipse.tm.terminal.control.ITerminalListener;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
The import org.eclipse.tm.terminal.control cannot be resolved
----------
4. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 43)
import org.eclipse.tm.terminal.control.ITerminalViewControl;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
The import org.eclipse.tm.terminal.control cannot be resolved
----------
5. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 44)
import
org.eclipse.tm.terminal.control.TerminalViewControlFactory;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
The import org.eclipse.tm.terminal.control cannot be resolved
----------
6. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 65)
public class TerminalView extends ViewPart implements
ITerminalView, ITerminalListener {
^^^^^^^^^^^^^^^^^
ITerminalListener cannot be resolved to a type
----------
7. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 68)
protected ITerminalViewControl fCtlTerminal;
^^^^^^^^^^^^^^^^^^^^
ITerminalViewControl cannot be resolved to a type
----------
8. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 151)
if(fCtlTerminal.getTerminalConnection()==null)
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
9. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 153)
fCtlTerminal.connectTerminal();
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
10. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 163)
boolean bEnabled = ((!isConnecting()) &&
(!fCtlTerminal.isConnected()));
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
11. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 169)
return fCtlTerminal.getState()==TerminalState.CONNECTING;
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
12. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 172)
return fCtlTerminal.getState()==TerminalState.CONNECTED;
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
13. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 175)
fCtlTerminal.disconnectTerminal();
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
14. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 179)
boolean bEnabled = ((isConnecting()) ||
(fCtlTerminal.isConnected()));
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
15. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 196)
TerminalSettingsDlg dlgTerminalSettings = new
TerminalSettingsDlg(getViewSite().getShell(),fCtlTerminal.getConnectors(
),fCtlTerminal.getTerminalConnection());
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
16. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 196)
TerminalSettingsDlg dlgTerminalSettings = new
TerminalSettingsDlg(getViewSite().getShell(),fCtlTerminal.getConnectors(
),fCtlTerminal.getTerminalConnection());
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
17. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 214)
fCtlTerminal.setConnector(connector);
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
18. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 220)
bEnabled = ((!isConnecting()) && (!fCtlTerminal
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
19. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 227)
if (fCtlTerminal.isDisposed())
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
20. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 238)
String strConnected =
getStateDisplayName(fCtlTerminal.getState());
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
21. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 240)
status=fCtlTerminal.getStatusString(strConnected);
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
22. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 267)
fCtlTerminal.getCtlText().setFont(JFaceResources.getFont(FONT_DEFINITION
));
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
23. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 271)
fCtlTerminal.onFontChanged();
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
24. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 275)
String selection=fCtlTerminal.getSelection();
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
25. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 278)
fCtlTerminal.copy();
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
26. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 280)
fCtlTerminal.sendKey('\u0003');
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
27. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 288)
bEnabled = fCtlTerminal.getSelection().length()>0;
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
28. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 295)
fCtlTerminal.sendKey('\u0018');
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
29. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 306)
fCtlTerminal.paste();
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
30. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 310)
String strText = (String)
fCtlTerminal.getClipboard().getContents(TextTransfer.getInstance());
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
31. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 318)
fCtlTerminal.clearTerminal();
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
32. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 322)
fActionEditClearAll.setEnabled(!fCtlTerminal.isEmpty());
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
33. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 326)
fCtlTerminal.selectAll();
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
34. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 330)
fActionEditSelectAll.setEnabled(!fCtlTerminal.isEmpty());
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
35. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 366)
fCtlTerminal.disposeTerminal();
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
36. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 372)
fCtlTerminal.setFocus();
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
37. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 380)
fCtlTerminal = TerminalViewControlFactory.makeControl(this,
wndParent, connectors);
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
38. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 380)
fCtlTerminal = TerminalViewControlFactory.makeControl(this,
wndParent, connectors);
^^^^^^^^^^^^^^^^^^^^^^^^^^
TerminalViewControlFactory cannot be resolved
----------
39. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 385)
fCtlTerminal.setConnector(connectors[i]);
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
40. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 389)
ITerminalConnector[] connectors=fCtlTerminal.getConnectors();
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
41. ERROR in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal.view/src/org/eclipse/tm/terminal/internal/view/TerminalView.java
(at line 466)
ctlText = fCtlTerminal.getCtlText();
^^^^^^^^^^^^
fCtlTerminal cannot be resolved
----------
41 problems (39 errors, 2 warnings)# 2/15/07 1:05:59 AM EST
# Eclipse Java Compiler 0.727, 3.3.0 milestone-4, Copyright IBM Corp
2000, 2006. All rights reserved.
----------
1. WARNING in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal/src/org/eclipse/tm/internal/terminal/control/impl/TerminalText.jav
a (at line 34)
import org.eclipse.tm.internal.terminal.telnet.TelnetConnection;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
The import org.eclipse.tm.internal.terminal.telnet.TelnetConnection is
never used
----------
----------
2. WARNING in
/home/data/users/moberhuber/ws2/working/build/plugins/org.eclipse.tm.ter
minal/src/org/eclipse/tm/internal/terminal/telnet/TelnetConnection.java
(at line 23)
import org.eclipse.tm.terminal.ITerminalControl;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
The import org.eclipse.tm.terminal.ITerminalControl is never used
----------
2 problems (2 warnings)
