Re: [dsdp-tm-dev] NLS warnings in example code

[David Dykstal <dykstal@xxxxxxx>]

In that case, I prefer (b). Either that or actually externalize the  
strings properly - but that would lessen the value of the tutorial.
---------------------------
Dave Dykstal
dykstal@xxxxxxx


On Dec 21, 2006, at 10:11 AM, Oberhuber, Martin wrote:

> Hi Dave,
>
> I don't think it is a good idea to have the actual example
> code different from what we have in the HTML help pages.
> I believe these should be verbatim copies.
>
> So there are two options --
> a) If we want to promote good practice, have //$NON-NLS-1$
>    in both the code and the HTML docs. Or,
> b) Don't use //$NON-NLS-1$ and change the example project's
>    .settings/org.eclipse.jdt.core.prefs in order to disable
>    the //$NON-NLS-1$ warnings for the example code.
>
> I don't have a clear personal preference for either (a)
> or (b). Thoughts?
>
> Cheers,
> --
> Martin Oberhuber
> Wind River Systems, Inc.
> Target Management Project Lead, DSDP PMC Member
> http://www.eclipse.org/dsdp/tm
>
> > -----Original Message-----
> > From: dsdp-tm-dev-bounces@xxxxxxxxxxx
> > [mailto:dsdp-tm-dev-bounces@xxxxxxxxxxx] On Behalf Of David Dykstal
> > Sent: Thursday, December 21, 2006 5:06 PM
> > To: Target Management developer discussions
> > Subject: [dsdp-tm-dev] NLS warnings in example code
> >
> > At one point we decided that it was appropriate to have NLS warnings
> > in example code. However, in the interest of keeping the noise level
> > down and promoting good practice I'd like to propose that we comment
> > the example code with $NON-NLS-x$ comments for strings. When we copy
> > this code for use in the tutorials, we should remove these comments.
> > This will keep the tutorials clean, and still provide warning-free
> > examples.
> >
> > Comments?
> > ---------------------------
> > Dave Dykstal
> > dykstal@xxxxxxx
> >
> >
> > _______________________________________________
> > dsdp-tm-dev mailing list
> > dsdp-tm-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/dsdp-tm-dev
> _______________________________________________
> dsdp-tm-dev mailing list
> dsdp-tm-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/dsdp-tm-dev