[dsdp-tcf-dev] [Bug 326270] New: [tcf] request of small amount of memory

[bugzilla-daemon@xxxxxxxxxxx]

https://bugs.eclipse.org/bugs/show_bug.cgi?id=326270 
Product/Component: Target Management / TCF

           Summary: [tcf] request of small amount of memory causes Byte64
                    conversion to "overflow" passed buffer
    Classification: DSDP
           Product: Target Management
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P3
         Component: TCF
        AssignedTo: dsdp.tm.tcf-inbox@xxxxxxxxxxx
        ReportedBy: kirk.beitz@xxxxxxxxx
         QAContact: martin.oberhuber@xxxxxxxxxxxxx


Build Identifier: 

in org.eclipse.tm.tcf.core/src/org/eclipse/tm/internal/tcf/services/remote in
MemoryProxy.java , MemoryProxy.MemContext#get()$MemoryCommand#done() can end up
with a perfectly valid 3-byte buffer that should be filled with the Byte64
filled string containing the values to place in the buffer.

however, the algorithm of JSON.toByteArray() will choke on this input.

(it's possible that the value passed back is not properly terminated, or that
JSON didn't take this into account; but it the conversion routine throws
IllegalArgumentException if the buffer is not big enough.)

I will attach a patch that causes this not to happen.

Reproducible: Always

Steps to Reproduce:
1. create a plug-in that uses TCF
2. attempt to get a 3-byte chunk of memory that will fail

if the portion of the code using TCF to retrieve memory fails with an unhandled
IllegalArgumentException in the call made from JSON.toByteArray() => FAIL

-- 
Configure bugmail: https://bugs.eclipse.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.