Re: [Dltk-dev] Number rule

[Alexey Panchenko <alex.panchenko@xxxxxxxxx>]

Hi,

Finally I've managed to combine universal enough FloatNumberRule class using different implementations as input.

http://git.eclipse.org/c/dltk/org.eclipse.dltk.core.git/commit/?id=b0bdf52ef4abe1ba1308da10d5fc074eaa61c45c

Let me know if it needs more extensibility and more tests :-)

Regards,

Alex

On Wed, Jul 18, 2012 at 12:04 AM, Kevin KIN-FOO <kkinfoo@xxxxxxxxxxxxxxxxxx> wrote:

Yes,

So far it is just this:
http://git.eclipse.org/c/koneki/org.eclipse.koneki.ldt.git/tree/plugins/org.eclipse.koneki.ldt.ui/src/org/eclipse/koneki/ldt/ui/internal/editor/text/LuaCodeScanner.java#n114
It needs more abstraction, I can do it if you are interested.

Regards

Le 17/07/2012 17:24, Alexey Panchenko a écrit :

Hi Kevin,

We already have language specific implementations for _javascript_, Ruby and TCL.

The grammars looks mostly the same, the only difference seems to be if hex numbers are supported with "0x" prefix or not.

You are right, it makes sense to extract the base class.

Just for the reference, could you provide the link to your implementation?

Thanks,

Alex

On Tue, Jul 17, 2012 at 8:48 PM, Kevin KIN-FOO <kkinfoo@xxxxxxxxxxxxxxxxxx> wrote:

Hi,

I extended org.eclipse.jface.text.rules.NumberRule to handle Lua numbers. And I wonder if it could interest you as default number rule in the DLTK framework.

Regards
_______________________________________________
dltk-dev mailing list
dltk-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dltk-dev

_______________________________________________
dltk-dev mailing list
dltk-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dltk-dev