Re: [Dltk-dev] new exception after yesterday's update

Hi Alex,

Yes, this patch works fine!

Thanks,

Michael

On Mon, Oct 19, 2009 at 1:30 PM, Alex Panchenko <alex@xxxxxxxxx> wrote:

Hi Michael,

Yes, it's exactly the reason.
I am pretty sure getBufferContent() should throw exception if resource doesn't exist, since it's used as the primary entry point to retrieve the module content.
JDT has additional checks in openBuffer(), so could you please check if this patch solves the issue: http://dl.getdropbox.com/u/229714/openBuffer.patch ?

Unfortunately, Untitled editor support is one of the features, implemented in PDT only, so it's hard to test it after the changes.
(As I remember another one is error highlighting for files outside of the workspace).

Thank you,
Alex

----- Original Message -----
From: "Michael Spector" <spektom@xxxxxxxxx>
To: "DLTK Developer Discussions" <dltk-dev@xxxxxxxxxxx>

Sent: Monday, October 19, 2009 5:54:28 PM GMT +06:00 Almaty, Novosibirsk
Subject: Re: [Dltk-dev] new exception after yesterday's update

Hi Alex,

I have found the fix in DLTK that introduced this issue with Untitled editor.
Can you look at your change at org.eclipse.dltk.internal.core.SourceModule.getBufferContent() in v.1.31?

Thanks,
Michael

On Mon, Oct 19, 2009 at 7:30 AM, Alex Panchenko <alex@xxxxxxxxx> wrote:

Hi Michael,

With this patch I don't have outline for external files opened via File - Open File.

Regards,

Alex

----- Original Message -----
From: "Michael Spector" <spektom@xxxxxxxxx>
To: "DLTK Developer Discussions" <dltk-dev@xxxxxxxxxxx>

Sent: Sunday, October 18, 2009 11:53:44 PM GMT +06:00 Almaty, Novosibirsk
Subject: Re: [Dltk-dev] new exception after yesterday's update

Hi Alex,

I was wrong - this isn't a regression (I haven't seen this failure, since the exception is not logged in SourceModuleDocumentProvider). Can you check the attached patch that fixes this problem?

I think ExternalSourceModule must be used in case of ExternalScriptProject :-)

Thanks!
Michael

On Thu, Oct 15, 2009 at 8:13 PM, Michael Spector <spektom@xxxxxxxxx> wrote:

Hi Alex,

It's as simple as creating an Untitled Editor (NonExistingEditorInput).

This feature is implemented in PDT (I don't know regarding other DLTK extenders)

Thanks,
Michael

On Thu, Oct 15, 2009 at 7:29 PM, Alex Panchenko <alex@xxxxxxxxx> wrote:

Hi Michael,

Could you please describe how to reproduce this issue?

Thank you,
Alex

----- Original Message -----
From: "Michael Spector" <spektom@xxxxxxxxx>
To: "DLTK Developer Discussions" <dltk-dev@xxxxxxxxxxx>
Sent: Thursday, October 15, 2009 9:52:23 PM GMT +06:00 Almaty, Novosibirsk
Subject: [Dltk-dev] new exception after yesterday's update

Hi,

I've started to get this exception on opening a non-existing file editor (Untitled Editor):

org.eclipse.dltk.core.ModelException: _27022227.php [in <default> [in <project root> [in ]]] does not exist

at org.eclipse.dltk.internal.core.ModelElement.newNotPresentException(ModelElement.java:256)
at org.eclipse.dltk.internal.core.SourceModule.getBufferContent(SourceModule.java:408)

at org.eclipse.dltk.internal.core.AbstractSourceModule.openBuffer(AbstractSourceModule.java:647)
at org.eclipse.dltk.internal.core.AbstractSourceModule.buildStructure(AbstractSourceModule.java:502)

at org.eclipse.dltk.internal.core.Openable.generateInfos(Openable.java:185)
at org.eclipse.dltk.internal.core.ModelElement.openWhenClosed(ModelElement.java:182)

at org.eclipse.dltk.internal.core.BecomeWorkingCopyOperation.executeOperation(BecomeWorkingCopyOperation.java:42)
at org.eclipse.dltk.internal.core.ModelOperation.run(ModelOperation.java:698)

at org.eclipse.dltk.internal.core.ModelOperation.runOperation(ModelOperation.java:764)
at org.eclipse.dltk.internal.core.SourceModule.becomeWorkingCopy(SourceModule.java:68)

at org.eclipse.dltk.core.WorkingCopyOwner.newWorkingCopy(WorkingCopyOwner.java:147)
at org.eclipse.dltk.internal.ui.editor.SourceModuleDocumentProvider.createFakeSourceModule(SourceModuleDocumentProvider.java:1659)

at org.eclipse.dltk.internal.ui.editor.SourceModuleDocumentProvider.createFakeSourceModule(SourceModuleDocumentProvider.java:1622)
at org.eclipse.dltk.internal.ui.editor.SourceModuleDocumentProvider.createFileInfo(SourceModuleDocumentProvider.java:1244)

It's really strange why does it check for the existence - shouldn't it be ExternalSourceModule at all?

Thanks,
Michael

_______________________________________________ dltk-dev mailing list dltk-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/dltk-dev

_______________________________________________

dltk-dev mailing list
dltk-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dltk-dev

_______________________________________________ dltk-dev mailing list dltk-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/dltk-dev

_______________________________________________
dltk-dev mailing list
dltk-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dltk-dev

_______________________________________________ dltk-dev mailing list dltk-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/dltk-dev

_______________________________________________
dltk-dev mailing list
dltk-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dltk-dev