[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [Dltk-dev] Re: HierarchyResolver performance improvement
|
Hi Michael,
1) I think it make sense to introduce
public final class NopTypeNameRequestor extends TypeNameRequestor,
since it is used in several places to warm up the search engine.
2) Type hierarchy does not look correct for Ruby (probably it was partially affected by https://bugs.eclipse.org/bugs/show_bug.cgi?id=260215 related changes, but the proposed changes add additional incorrectness too), so more time is required to review/improve these changes.
a.rb:
class AAA
end
b.rb:
class BBB < AAA
end
and call hierarchy for BBB.
I hope to find time to look it thoroughly during weekend or on Monday.
Thank you,
Alex
----- Original Message -----
From: "Michael Spector" <spektom@xxxxxxxxx>
To: "DLTK Developer Discussions" <dltk-dev@xxxxxxxxxxx>
Sent: Thursday, April 16, 2009 10:08:15 PM GMT +06:00 Almaty, Novosibirsk
Subject: [Dltk-dev] Re: HierarchyResolver performance improvement
Sorry, here's the correct link:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=272513
On Thu, Apr 16, 2009 at 6:07 PM, Michael Spector <spektom@xxxxxxxxx> wrote:
> Hi All,
>
> Please see this bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=272423
> I've attached a patch that dramatically improves the hierarchy
> resolver performance. If none has any objections - I'll commit it.
>
> PS: there's a small API change, I've changed all parts that depend on
> TypeNameRequestor.
>
> Thanks in advance.
>
> --
> Best regards,
> Michael
>
--
Best regards,
Michael
_______________________________________________
dltk-dev mailing list
dltk-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dltk-dev
